Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: support DROP FOREIGN KEY statement #14338

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

For the ongoing, experimental foreign key support, this PR adds support for ALTER TABLE ... DROP FOREIGN KEY. As you might see from the change, there's very little to this PR; all the support has been created long ago, but due to an oversight we did not include DROP FOREIGN KEY in the logic.

Just to explain the change: in Online DDL we actually drop the foreign key on the shadow table. Since foreign key constraints, like check constraints, have schema-level naming scope, the shadow table's foreign key constraint is different than the original's.

Without this PR, a ALTER TABLE t DROP FOREIGN KEY t_id_fk fails because it attempts to drop the constraint t_id_fk from the shadow tables. But on the shadow table the constraint might be named e.g. fk_aulpn7bjeortljhguy86phdn9. The fix in this PR is to use the constraint mapping between original and shadow table.

Related Issue(s)

Tracking: #11975

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Oct 23, 2023
@shlomi-noach shlomi-noach requested a review from a team October 23, 2023 10:49
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 23, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 23, 2023
Signed-off-by: Shlomi Noach <[email protected]>
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 23, 2023
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach merged commit 64085d8 into vitessio:main Oct 25, 2023
117 checks passed
@shlomi-noach shlomi-noach deleted the onlineddl-drop-fk-map branch October 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants