Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace into statement plan with foreign keys : unsharded #14396

Merged
merged 20 commits into from
Nov 15, 2023
Merged

Replace into statement plan with foreign keys : unsharded #14396

merged 20 commits into from
Nov 15, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Oct 30, 2023 •
edited
Loading

Description

This PR adds support for REPLACE INTO statement for unsharded keyspace having foreign keys.

Edit: This modifies to only add planner side changes and fails on execution.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 30, 2023
@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 30, 2023
@vitess-bot vitess-bot bot mentioned this pull request Oct 30, 2023
Closed
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 30, 2023
@harshit-gangal harshit-gangal marked this pull request as ready for review November 2, 2023 11:39
GuptaManan100
GuptaManan100 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

go/vt/vtgate/engine/sequential.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/operators/insert.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/operators/insert.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/sequential.go Outdated Show resolved Hide resolved
harshit-gangal and others added 18 commits November 13, 2023 12:45
@harshit-gangal
feat: retrieve and store indexes from ddl on table info in schema tra…
95a6673 
…cking

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
update vschema using schema tracking indexes information
97a1462 
Signed-off-by: Harshit Gangal <[email protected]>
@GuptaManan100 @harshit-gangal
serialize engine and operator
f3c6e92 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
feat: add support for replace into query with foreign key in unsharde…
2a01008 
…d keyspace

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
prevent auto-commit for unsharded dml when using sequential engine
77e966e 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
omit empty in vschema table json marshal
31e8881 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
fix replace planner and allow only when primarykey or uniquekey is known
f569ddf 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
sizegen: update
612d513 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
fix the sequential condition
150bdc5 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
track column default
d1ef281 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
fix tracker test after key formatting change
4b6c0a1 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
use column default when column not present in replace into query
39ef21d 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
fix: sequential engine to append the rowsAffected, take insertID and …
c661fda 
…one of the Info while producing the final result set

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
unique keys to add when can return rows on delete, added tests
e792ac6 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
add fuzzer test for replace into
6fca56a 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
addressed review comments
7806d1e 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
added replace fk fuzz test
601133f 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
address review comments
63a9075 
Signed-off-by: Harshit Gangal <[email protected]>
frouioui
frouioui reviewed Nov 13, 2023
View reviewed changes
go/test/endtoend/vtgate/foreignkey/fk_fuzz_test.go
Comment on lines +607 to +616
}, {
name: "Multi Thread - Balanced Inserts, Updates and Deletes",
concurrency: 30,
timeForTesting: 5 * time.Second,
maxValForCol: 5,
maxValForId: 30,
insertShare: 50,
deleteShare: 50,
updateShare: 50,
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this test is failing on CI:

    --- FAIL: TestFkFuzzTest/Unsharded_-_Multi_Thread_-_Balanced_Inserts,_Updates_and_Deletes_QueryFormat_-_PreparedStatementPacket (4.78s)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure looks unrelated to this PR. Investigating it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR that fixes the issue #14524

systay
systay reviewed Nov 15, 2023
View reviewed changes
go/vt/vtgate/engine/sequential.go

// TryExecute performs a non-streaming exec.
func (s *Sequential) TryExecute(ctx context.Context, vcursor VCursor, bindVars map[string]*querypb.BindVariable, wantFields bool) (*sqltypes.Result, error) {
return nil, vterrors.VT10002()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what am I missing here? why error on both execute methods?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace into plan execution is disabled as of now as there is an inherent issue with locking rows with unique keys.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exposed an issue with mysql locking with unique key. A follow up PR will add the support for it on the engine.

systay
systay reviewed Nov 15, 2023
View reviewed changes
go/vt/vtgate/planbuilder/operators/insert.go
def sqlparser.Expr
}

func uniqKeyCompExpressions(vTbl *vindexes.Table, ins *sqlparser.Insert, rows sqlparser.Values) (comps []*sqlparser.ComparisonExpr, err error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use panic(err) instead of returning errors in the operator package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change in followup PR

@harshit-gangal harshit-gangal merged commit 9ddf932 into vitessio:main Nov 15, 2023
118 checks passed
@harshit-gangal harshit-gangal deleted the replace-plan branch November 15, 2023 18:15
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@harshit-gangal @GuptaManan100 @ejortegau
Replace into statement plan with foreign keys : unsharded (vitessio…
f2b9ef8 
…#14396)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui left review comments

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

Assignees
No one assigned
Labels
Component: Query Serving Type: Feature
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@harshit-gangal @systay @frouioui @GuptaManan100