Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mismatch in column count and value count #14417

Merged
merged 12 commits into from
Nov 21, 2023
Merged

fix: mismatch in column count and value count #14417

merged 12 commits into from
Nov 21, 2023

Conversation

FirePing32
Copy link
Contributor

Description

Checks if the column count is equal to the row value count

Related Issue(s)

fixes: #14322

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 1, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 1, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 1, 2023
@dbussink
Copy link
Contributor

dbussink commented Nov 5, 2023

@FirePing32 can you add a test for this as well?

@dbussink dbussink added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 5, 2023
@FirePing32 FirePing32 force-pushed the fix-planbuilder-insert branch from 8114c03 to 0f32219 Compare November 5, 2023 16:37
@FirePing32
add newline
236caba 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
fix: goimports
87b1d5b 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
fix: sql query
c5c1b0d 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
Copy link
Contributor Author

@dbussink The unit tests are failing.

[BUG] should only be used for single tables

I get this, but the test SQL query I have used only targets 1 table.

@FirePing32
tests: use e2e
088697b 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
add dml tests
fb8abb5 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
update dml query
fe5cec5 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
Copy link
Contributor Author

@GuptaManan100 @dbussink Please merge.

@FirePing32
change test table
2888bf2 
Signed-off-by: Prakhar Gurunani <[email protected]>
@FirePing32
update plan
4b545e9 
Signed-off-by: Prakhar Gurunani <[email protected]>
GuptaManan100
GuptaManan100 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thank-you for your contribution!

@GuptaManan100 GuptaManan100 merged commit 4f08558 into vitessio:main Nov 21, 2023
115 checks passed
@FirePing32 FirePing32 deleted the fix-planbuilder-insert branch November 21, 2023 19:36
@FirePing32 FirePing32 restored the fix-planbuilder-insert branch November 21, 2023 19:36
@goooooooooooooood
Copy link

new bee

ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@FirePing32 @ejortegau
fix: mismatch in column count and value count (vitessio#14417)
6547619 
Signed-off-by: Prakhar Gurunani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.0
5 participants
@FirePing32 @dbussink @goooooooooooooood @frouioui @GuptaManan100