Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Usage of VReplicationExec For _vt.vreplication Reads #14424

Merged
merged 46 commits into from
Mar 11, 2024

Minor changes after self review of new code

60f7d05
Select commit
Loading
Failed to load commit list.
Merged

Remove Usage of VReplicationExec For _vt.vreplication Reads #14424

Minor changes after self review of new code
60f7d05
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 10, 2024 in 1s

48.12% of diff hit (target 67.41%)

View this Pull Request on Codecov

48.12% of diff hit (target 67.41%)

Annotations

Check warning on line 96 in go/cmd/vtctldclient/command/vreplication/materialize/create.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/vreplication/materialize/create.go#L96 

Added line #L96 was not covered by tests

Check warning on line 84 in go/vt/discovery/tablet_picker.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/discovery/tablet_picker.go#L84 

Added line #L84 was not covered by tests

Check warning on line 877 in go/vt/vtcombo/tablet_map.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtcombo/tablet_map.go#L876-L877 

Added lines #L876 - L877 were not covered by tests

Check warning on line 881 in go/vt/vtcombo/tablet_map.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtcombo/tablet_map.go#L880-L881 

Added lines #L880 - L881 were not covered by tests

Check warning on line 901 in go/vt/vtcombo/tablet_map.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtcombo/tablet_map.go#L900-L901 

Added lines #L900 - L901 were not covered by tests

Check warning on line 78 in go/vt/vtctl/workflow/materializer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/materializer.go#L77-L78 

Added lines #L77 - L78 were not covered by tests

Check warning on line 453 in go/vt/vtctl/workflow/materializer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/materializer.go#L453 

Added line #L453 was not covered by tests

Check warning on line 83 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L83 

Added line #L83 was not covered by tests

Check warning on line 91 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L91 

Added line #L91 was not covered by tests

Check warning on line 98 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L98 

Added line #L98 was not covered by tests

Check warning on line 106 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L106 

Added line #L106 was not covered by tests

Check warning on line 119 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L119 

Added line #L119 was not covered by tests

Check warning on line 137 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L137 

Added line #L137 was not covered by tests

Check warning on line 139 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L139 

Added line #L139 was not covered by tests

Check warning on line 142 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L141-L142 

Added lines #L141 - L142 were not covered by tests

Check warning on line 155 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L154-L155 

Added lines #L154 - L155 were not covered by tests

Check warning on line 157 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L157 

Added line #L157 was not covered by tests

Check warning on line 159 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L159 

Added line #L159 was not covered by tests

Check warning on line 178 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L177-L178 

Added lines #L177 - L178 were not covered by tests

Check warning on line 185 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L181-L185 

Added lines #L181 - L185 were not covered by tests

Check warning on line 188 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L187-L188 

Added lines #L187 - L188 were not covered by tests

Check warning on line 198 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L190-L198 

Added lines #L190 - L198 were not covered by tests

Check warning on line 202 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L200-L202 

Added lines #L200 - L202 were not covered by tests

Check warning on line 204 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L204 

Added line #L204 was not covered by tests

Check warning on line 208 in go/vt/vtctl/workflow/resharder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/resharder.go#L207-L208 

Added lines #L207 - L208 were not covered by tests
View more details on Codecov