Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash joins when nested loop joins are not feasible #14448

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 3, 2023

Description

The join we to use in vtgate is the apply join, also known as nested loop join. It's algorithm is pretty straight forward - we execute the query on the LHS of the join, and then, for each row in this result, we extract the join columns from the left and push them down on the RHS of the join, and use them for filtering there.

This works well in most situations. One issue is that we can't have the outer side on the LHS of the join - we won't see the values that are coming from the RHS that don't match anything on the left.

Another limitation is that we can't really have LIMIT on the RHS either. Our engine primitives understand a call to the Execute method as a new query. Since we will need to do multiple Execute calls on the RHS, LIMITs there will produce too many rows. A LIMIT 10 will produce 10 rows per row on the LHS, and that is not correct.

To solve this, we have a couple of options. One would be to introduce a query scope for the engine primitives.
In this PR I'm trying using the hash join engine primitive for these queries. Since it executes the LHS and the RHS on their own and then joins the result, we can allow outer joins and limits on either/both sides.

Related Issue(s)

Fixes #11879

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Nov 3, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 3, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 3, 2023
@systay systay added Type: Feature Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 3, 2023
@systay systay force-pushed the use-hash-joins branch 6 times, most recently from 6768501 to 61a1344 Compare November 14, 2023 07:52
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Type: Feature labels Nov 14, 2023
@systay
Copy link
Collaborator Author

systay commented Nov 16, 2023

The produced plans still need optimising - this PR only makes the queries possible, they are still going to be very slow. Optimisation work incoming

Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking gucci my friend

@systay systay merged commit 09715e3 into vitessio:main Nov 16, 2023
115 checks passed
@systay systay deleted the use-hash-joins branch November 16, 2023 09:43
@systay systay mentioned this pull request Nov 30, 2023
4 tasks
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: v14.0.4 raises unsupported error with a derived table on a reference table
3 participants