Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: fix numeric coercibility #14473

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Nov 6, 2023

Description

@systay discovered this issue during fuzzing. We need special handling for the coercibility of numeric types in the evalengine, otherwise some case expressions will not be collated as text as you'd expect.

We've fixed the issue by replacing the generic defaultCoercionCollation helper with an enhanced version that takes into account the type of the value being collated. This also fixes mismatched collations for some datetime and JSON values.

Here's an example of an expression that had the right return type, but the wrong collation before this change:

			expression: `case column0 when 1 then column1 else column2 end`,
			values:     []sqltypes.Value{sqltypes.NewInt64(42), sqltypes.NewVarChar("sole"), sqltypes.NewInt64(0)},
			result:     `VARCHAR("0")`,
			collation:  collations.CollationUtf8mb4ID,

cc @dbussink

Related Issue(s)

Fixes #14480

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Nov 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 6, 2023
@vmg vmg marked this pull request as ready for review November 6, 2023 11:57
@vmg vmg added Type: Bug Type: Internal Cleanup Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 6, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 6, 2023
@vmg vmg requested a review from shlomi-noach as a code owner November 6, 2023 13:37
@@ -68,6 +68,7 @@ func createUncertain(direct TableSet, recursive TableSet) *uncertain {
dependency: dependency{
direct: direct,
recursive: recursive,
typ: evalengine.UnknownType(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not being initialized as Unknown, so it was propagating as NULL.

@@ -58,11 +58,10 @@ func (t *typer) up(cursor *sqlparser.Cursor) error {
if !ok {
return nil
}
var inputType sqltypes.Type
inputType := sqltypes.Unknown
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This was not being initialized as Unknown.

@systay systay force-pushed the vmg/evalengine-numeric-coerce branch from 06d2d5e to 492ca0d Compare November 6, 2023 15:39
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fuzzer to find that we're not doing this right before and using the wrong coercions!

@vmg vmg merged commit a7a44c6 into vitessio:main Nov 6, 2023
115 checks passed
@vmg vmg deleted the vmg/evalengine-numeric-coerce branch November 6, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type in output with CASE and literals
3 participants