-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-18.0] Build and push Docker Images from GitHub Actions #14511
Merged
deepthi
merged 4 commits into
vitessio:release-18.0
from
planetscale:backport-docker-auto-build-on-18
Nov 14, 2023
Merged
[release-18.0] Build and push Docker Images from GitHub Actions #14511
deepthi
merged 4 commits into
vitessio:release-18.0
from
planetscale:backport-docker-auto-build-on-18
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
requested review from
rohit-nayak-ps,
deepthi,
derekperkins,
dkhenry,
mattlord and
GuptaManan100
as code owners
November 13, 2023 18:07
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 13, 2023
…itessio#14243) Signed-off-by: Florent Poinsard <[email protected]>
… from GitHub Actions (vitessio#14271) Signed-off-by: Florent Poinsard <[email protected]>
…ions (vitessio#14314) Signed-off-by: Florent Poinsard <[email protected]>
) Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
backport-docker-auto-build-on-18
branch
from
November 13, 2023 18:08
ccfd6bc
to
34b1285
Compare
frouioui
changed the title
Build and push Docker
[release-18.0] Build and push Docker Images from GitHub Actions
Nov 13, 2023
vitess/lite
to DockerHub from GitHub Actions (#…
frouioui
added
Type: CI/Build
Backport
This is a backport
Component: Docker
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 13, 2023
harshit-gangal
approved these changes
Nov 14, 2023
deepthi
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the auto build of Docker Images in GHA instead of Docker Hub. List of backported PRs:
vitess/lite
to DockerHub from GitHub Actions #14243vitess/base
and component images to DockerHub from GitHub Actions #14271vitess/vttestserver
DockerHub from GitHub Actions #14314vtexplain
andvtbackup
to base docker auto-build #14318