[release 18.0]: ReadBinlogFilesTimestamps backwards compatibility

[shlomi-noach]

Description

Fixes #14506

This PR contains two fixes:

1. Similarly to MysqlCtl: implement missing ReadBinlogFilesTimestamps function #14525, implements ReadBinlogFilesTimestamps.
2. Adds backwards compatibility to ReadBinlogFilesTimestamps invocation. ReadBinlogFilesTimestamps was introduced in v18. If a v18 vtctldclient calls a v17 mysqlctld daemon, then that daemon does not implement said function. The solution here is to check the returned error, and ignore accordingly. It's a bit ugly, and it's a workaround to something we should not have introduced in a single step.

Related Issue(s)

#14506

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[marf]

Hello, has this been released to 18.0.1 ? Because I upgraded my cluster but I still have the issue.

[shlomi-noach]

It has indeed been released in 18.0.1 and tested, I'm unsure how you might still be seeing the issue. The fix in 18.0.1 both implements the missing function as well as ignores a gRPC error saying it does not exist.

[marf]

It has indeed been released in 18.0.1 and tested, I'm unsure how you might still be seeing the issue. The fix in 18.0.1 both implements the missing function as well as ignores a gRPC error saying it does not exist.

Yeah, sorry now it seems to work. Thanks!

[shlomi-noach]

Phew! Thank you for testing!