Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excessive VTGate logging of default planner selection #14554

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Remove excessive VTGate logging of default planner selection #14554

merged 1 commit into from
Nov 21, 2023

Conversation

harshit-gangal
Copy link
Member

Description

This PR remove the excessive logging for Gen4 as default planner.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@harshit-gangal
remove default planner log
4ff1f11 
Signed-off-by: Harshit Gangal <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 20, 2023 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 20, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 20, 2023
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 20, 2023
@dbussink dbussink merged commit 49a1154 into vitessio:main Nov 21, 2023
123 checks passed
@dbussink dbussink deleted the remove-gen4-log branch November 21, 2023 12:35
@vitess-bot vitess-bot bot mentioned this pull request Nov 21, 2023
Merged
vitess-bot pushed a commit that referenced this pull request Nov 21, 2023
@vitess-bot
Remove excessive VTGate logging of default planner selection (#14554)
4656185 
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal pushed a commit that referenced this pull request Nov 21, 2023
@vitess-bot
[release-18.0] Remove excessive VTGate logging of default planner sel…
2b18d94 
…ection (#14554) (#14561)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@harshit-gangal @ejortegau
Remove excessive VTGate logging of default planner selection (vitessi…
ae1dad9 
…o#14554)

Signed-off-by: Harshit Gangal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@dbussink dbussink dbussink approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving go Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Question: Since V18 update I have a lot of vtgate logs saying Using Gen4 planner instead of DEFAULT_PLANNER
3 participants
@harshit-gangal @dbussink @deepthi