-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide subset of shards for certain VReplication Commands #14601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables supported, for safety and since that is the main use case of --shards. Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: VReplication
Backport to: release-17.0
labels
Nov 24, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 24, 2023
rohit-nayak-ps
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 24, 2023
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
removed
Backport to: release-17.0
NeedsWebsiteDocsUpdate
What it says
labels
Nov 25, 2023
Signed-off-by: Rohit Nayak <[email protected]>
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
github-actions
bot
added
Stale
Marks PRs as stale after a period of inactivity, which are then closed after a grace period.
and removed
Stale
Marks PRs as stale after a period of inactivity, which are then closed after a grace period.
labels
Dec 28, 2023
Replaced by #14873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For clusters with large number of shards, when there are workflows which only have a few participating shards, like Partial MoveTables for example, there is a huge overhead when commands contact all primaries in a keyspace with most returning no results.
This PR adds a
--shards
option for the vtctlclient and the vtctldclient forWorkflow
command so thatShow
,Stop
,Start
andDelete
only operate on the specified shards.MoveTables
command (only for partial move tables) for all sub-commands exceptCreate
.Note that we expect the user to know what they are doing since we don't validate that the specified workflows are not present on other shards and hence can result in only a few streams being updated and potentially cause data loss and cluster inconsistencies if this is done for
SwitchTraffic
for example.Related Issue(s)
Fixes: #14204