Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the INSERT engine primitive #14606

Merged
merged 15 commits into from
Nov 29, 2023
Merged

refactor the INSERT engine primitive #14606

merged 15 commits into from
Nov 29, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 27, 2023 •
edited by harshit-gangal
Loading

Description

This PR splits the Insert engine primitive into two primitives one with Insert using Row Values and another with Insert using Select Statement.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 27, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 27, 2023
@harshit-gangal harshit-gangal force-pushed the insert-refactor branch 2 times, most recently from 3232270 to aed6bd8 Compare November 27, 2023 11:18
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Nov 27, 2023
systay and others added 8 commits November 27, 2023 23:23
@systay @harshit-gangal
refactor: move the use of Input over to InsertRows for unsharded
40061cc 
Signed-off-by: Andres Taylor <[email protected]>
@systay @harshit-gangal
refactor: move all uses of the Input field to InsertRows
ca02aff 
Signed-off-by: Andres Taylor <[email protected]>
@harshit-gangal
refactor: moved sequence Generate to InsertRows
3bf6f59 
Signed-off-by: Harshit Gangal <[email protected]>
@systay @harshit-gangal
refactor: reuse existing helper methods
9c2d2f3 
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
refactor: move Generate to InsertRows for sqlparer.Values
fd2f7f8 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
refactor: split insert engine to insert and insertSelect
db61637 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
refactor: removed unused code from new engine primitives
71abc7c 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
refactor: moved some part to insert common
82acc31 
Signed-off-by: Harshit Gangal <[email protected]>
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 28, 2023
@harshit-gangal harshit-gangal marked this pull request as ready for review November 29, 2023 07:18
systay
systay commented Nov 29, 2023
View reviewed changes
go/vt/vtgate/engine/insert.go Outdated Show resolved Hide resolved
systay
systay commented Nov 29, 2023
View reviewed changes
go/vt/vtgate/engine/insert.go Outdated Show resolved Hide resolved
systay
systay commented Nov 29, 2023
View reviewed changes
go/vt/vtgate/engine/insert.go Outdated Show resolved Hide resolved
systay
systay commented Nov 29, 2023
View reviewed changes
go/vt/vtgate/engine/insert.go Outdated Show resolved Hide resolved
@harshit-gangal
addressed review comments
514cd98 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
sizegen update
e50243a 
Signed-off-by: Harshit Gangal <[email protected]>
systay
systay commented Nov 29, 2023
View reviewed changes
Copy link
Collaborator Author

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @harshit-gangal

The code reads much better now

@harshit-gangal harshit-gangal merged commit b397718 into vitessio:main Nov 29, 2023
116 checks passed
@harshit-gangal harshit-gangal deleted the insert-refactor branch November 29, 2023 17:15
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@systay @harshit-gangal @ejortegau
refactor the INSERT engine primitive (vitessio#14606)
277d786 
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Harshit Gangal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @harshit-gangal @GuptaManan100