Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable test in downgrade testing #14625

Merged
merged 2 commits into from
Jan 9, 2024
Merged

test: enable test in downgrade testing #14625

merged 2 commits into from
Jan 9, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 28, 2023

Description

Enables a downgrade test for V18.

In #14607 a bug was fixed, that was also present in V18. We had to disable the downgrade test for this fix since the fix had not been backported to V18 and was failing CI.

That fix has since been backported and merged into V18, so we can enable the downgrade testing.

Related Issue(s)

Original fix #14607
Backport to V18 #14615

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 28, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 28, 2023
@systay systay added Component: Query Serving Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 28, 2023
GuptaManan100
GuptaManan100 reviewed Nov 28, 2023
View reviewed changes
go/test/endtoend/vtgate/queries/subquery/subquery_test.go
Comment on lines -61 to -62
utils.SkipIfBinaryIsBelowVersion(t, 19, "vtgate")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you still need to skip the test if the vtgate version in less than v18 if it doesn't work with v18 vtgate

@systay
Copy link
Collaborator Author

systay commented Nov 28, 2023

this PR is blocked waiting for the next v18 release

@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Dec 29, 2023
@frouioui frouioui removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 3, 2024
@harshit-gangal harshit-gangal merged commit f2e0ea3 into vitessio:main Jan 9, 2024
99 checks passed
@harshit-gangal harshit-gangal deleted the remove-test branch January 9, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 left review comments

@frouioui frouioui frouioui approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@vmg vmg vmg approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Testing
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@systay @dbussink @vmg @shlomi-noach @frouioui @GuptaManan100 @harshit-gangal