Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license header typo #14630

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix license header typo #14630

merged 1 commit into from
Nov 29, 2023

Conversation

frouioui
Copy link
Member

Fix a small typo found across several files.

@frouioui
fix license header typo
7dbf7d7 
Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 28, 2023
@frouioui frouioui added Type: Internal Cleanup Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 28, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 28, 2023
ajm188
ajm188 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man, this must have been there a while, thanks! 😂

@frouioui
Copy link
Member Author

oh man, this must have been there a while, thanks! 😂

Randomly found this while copy-pasting some code 😆

@ajm188
Copy link
Contributor

ajm188 commented Nov 29, 2023

oh man, this must have been there a while, thanks! 😂

Randomly found this while copy-pasting some code 😆

i'm the one that copy-pasted it to here without noticing 😂

@ajm188 ajm188 merged commit f892be0 into vitessio:main Nov 29, 2023
120 of 121 checks passed
@ajm188 ajm188 deleted the fix-license branch November 29, 2023 13:04
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@frouioui @ejortegau
Fix license header typo (vitessio#14630)
372d3e7 
Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @ajm188 @dbussink