Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyspace ServedFrom: remove this deprecated attribute and related code #14694

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Keyspace ServedFrom: remove this deprecated attribute and related code #14694

merged 5 commits into from
Dec 11, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Dec 6, 2023 •
edited
Loading

Description

ServedFrom has been deprecated for a while since we deprecated the older resharding workflows. Remove all references to it from code and tests and mark related proto attributes as reserved.

Related Issue(s)

Fixes #14695

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 6, 2023
@rohit-nayak-ps rohit-nayak-ps added Type: Internal Cleanup Component: General Changes throughout the code base labels Dec 6, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 6, 2023
@rohit-nayak-ps
Fix failing tests
6268b22 
Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 6, 2023
rohit-nayak-ps
rohit-nayak-ps commented Dec 6, 2023
View reviewed changes
go/vt/topo/locks.go
// - 'vtctl SetShardTabletControl' emergency operations
// - 'vtctl SourceShardAdd' and 'vtctl SourceShardDelete' emergency operations
//
// * keyspace-wide schema changes
func (ts *Server) LockKeyspace(ctx context.Context, keyspace, action string) (context.Context, func(*error), error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this outdated comment. We should be using the IDE to find all Usages rather than maintaining such a list here.

rohit-nayak-ps
rohit-nayak-ps commented Dec 6, 2023
View reviewed changes
go/vt/topotools/keyspace.go
return false
}
}
if left.KeyspaceType != right.KeyspaceType {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check was repeated

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review December 6, 2023 09:19
mattlord
mattlord approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bit of cleanup! ❤️

proto/vttest.proto Outdated
// redirects all traffic to another keyspace. If set, shards is ignored.
string served_from = 5;

//string served_from = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to note that it's OBSOLETE?

@rohit-nayak-ps
Add missing obsolete comment
cbbb63e 
Signed-off-by: Rohit Nayak <[email protected]>
@deepthi deepthi merged commit 21b490a into vitessio:main Dec 11, 2023
119 checks passed
@deepthi deepthi deleted the deprecate-served-from branch December 11, 2023 23:31
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@rohit-nayak-ps @ejortegau
Keyspace ServedFrom: remove this deprecated attribute and related code (
a8550d8 
vitessio#14694)

Signed-off-by: Rohit Nayak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@deepthi deepthi deepthi approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Internal Cleanup: Remove deprecated ServedFrom attribute from the topo Keyspace object
3 participants
@rohit-nayak-ps @deepthi @mattlord