schemadiff: pursue foreign key errors and proceed to build schema #14705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
shlomi-noach
removed
NeedsDescriptionUpdate
GuptaManan100
approved these changes
Dec 6, 2023
mattlord
approved these changes
Dec 6, 2023
| @@ -241,10 +253,12 @@ func (s *Schema) normalize() error { | |||
| } | |||
| referencedEntity, ok := s.named[referencedTableName] | |||
| if !ok { | |||
| return &ForeignKeyNonexistentReferencedTableError{Table: name, ReferencedTable: referencedTableName} | |||
| errs = errors.Join(errs, addEntityFkError(t, &ForeignKeyNonexistentReferencedTableError{Table: name, ReferencedTable: referencedTableName})) | |||
There was a problem hiding this comment.
I was going to ask if we wanted to add/join nil errors as well, but then saw the docs: https://pkg.go.dev/errors#Join :-)
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Dec 13, 2023
…tessio#14705) Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When parsing/reading a
Schemaobject, we now pursue reading and mapping all tables, even if we hit foreign key definition errors. We take note and aggregate all errors, and at the end we still list all input tables, whether they do have errors or not.Normally, when the caller of e.g.
s, err := NewSchemaFromEntities(...)gets a non nilerr, they bail out. But it is also possible for them to unwrap the list of errors, or even pry open the schema (if non-nil) and read the list of whatever tables they can find.Related Issue(s)
Checklist