Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flush tables with read lock to run only with reserved connection #14720

Merged
merged 6 commits into from
Dec 8, 2023
Merged

fix: flush tables with read lock to run only with reserved connection #14720

merged 6 commits into from
Dec 8, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 7, 2023 •
edited
Loading

Description

This PR makes Flush Tables With Read Lock to run with a dedicated connection so that VTGate session can track the connection and use it to execute Unlock Tables on it or if the VTGate session is closed, the connection can be closed as well. This prevents other sessions from being stuck forever for the unlock of tables.

It is a kind of breaking change. But, a good one as it prevents users from being stuck forever after one of the session executes Flush Tables With Read Lock

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 7, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 7, 2023
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 7, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 7, 2023
@harshit-gangal harshit-gangal marked this pull request as ready for review December 7, 2023 18:42
systay
systay reviewed Dec 8, 2023
View reviewed changes
go/test/endtoend/vtgate/misc_test.go
@@ -336,6 +340,51 @@ func TestFlush(t *testing.T) {
utils.Exec(t, conn, "flush local tables t1, t2")
}

func TestFlushLock(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment describing what you are testing here?

@harshit-gangal
addressed review comments
bbb3df5 
Signed-off-by: Harshit Gangal <[email protected]>
GuptaManan100
GuptaManan100 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@harshit-gangal
add table qualifier
31a72ff 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal merged commit 27f1ac2 into vitessio:main Dec 8, 2023
116 checks passed
@harshit-gangal harshit-gangal deleted the ftwrl branch December 8, 2023 17:16
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@harshit-gangal @ejortegau
fix: flush tables with read lock to run only with reserved connection (…
6c68227 
…vitessio#14720)

Signed-off-by: Harshit Gangal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@systay systay systay approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: FLUSH TABLES WITH READ LOCK will lock a Vitess database in a way that is not recoverable by user
4 participants
@harshit-gangal @systay @frouioui @GuptaManan100