Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Improve replication plan error messages #14752

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Dec 11, 2023

Description

We did not have documentation covering the limitations of materialization queries used in VReplication workflows. This is primarily a consideration for the Materialize command where you a specify an arbitrary query to materialize in a new table vs. the other workflows (e.g. MoveTables and Reshard) where we're generally copying table data rather than query results.

On top of that, most of the errors resulting from the use of unsupported SQL constructs in Materialize queries did not make it clear what in the query was unsupported. For example:

"Message": "unexpected: select car.id, car.make, car.model, car.`year`, car.mileage, car.price, JSON_ARRAYAGG(json_object('start', booking.start_time, 'end', booking.end_time)) as booked_times from car left join booking on car.id = booking.car_id group by car.id",

The primary cause of the failure above is the JOIN as the big general limitation is that you must use a single table -- this limitation coming from the replication phase where we need to apply binlog events and lack the ability to (easily) maintain the JOIN results when doing so. But because we don't clearly document the limitations and the error is clearly not helpful in that regard, a user would have no idea why things aren't working.

This PR aims to improve the error messages AND serve as the basis for a documentation PR where we lay out the main limitations.

Related Issue(s)

Checklist

Copy link
Contributor

vitess-bot bot commented Dec 11, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 11, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 11, 2023
Signed-off-by: Matt Lord <[email protected]>
Copy link
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of improved error messages

@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Dec 12, 2023
@mattlord mattlord added Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Documentation labels Dec 12, 2023
@mattlord mattlord marked this pull request as ready for review December 16, 2023 01:38
@mattlord mattlord removed the NeedsWebsiteDocsUpdate What it says label Dec 20, 2023
@mattlord mattlord merged commit 4200295 into vitessio:main Dec 20, 2023
116 of 117 checks passed
@mattlord mattlord deleted the vrepl_misc_tweaks branch December 20, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Documentation Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

meterialize: Getting 'unexpected error' when making a workflow with sql join query
3 participants