-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Improve replication plan error messages #14752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 11, 2023
Signed-off-by: Matt Lord <[email protected]>
derekperkins
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of improved error messages
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
labels
Dec 12, 2023
mattlord
added
Component: VReplication
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Documentation
labels
Dec 12, 2023
Signed-off-by: Matt Lord <[email protected]>
rohit-nayak-ps
approved these changes
Dec 19, 2023
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VReplication
Type: Documentation
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We did not have documentation covering the limitations of materialization queries used in VReplication workflows. This is primarily a consideration for the
Materialize
command where you a specify an arbitrary query to materialize in a new table vs. the other workflows (e.g.MoveTables
andReshard
) where we're generally copying table data rather than query results.On top of that, most of the errors resulting from the use of unsupported SQL constructs in
Materialize
queries did not make it clear what in the query was unsupported. For example:The primary cause of the failure above is the
JOIN
as the big general limitation is that you must use a single table -- this limitation coming from the replication phase where we need to apply binlog events and lack the ability to (easily) maintain the JOIN results when doing so. But because we don't clearly document the limitations and the error is clearly not helpful in that regard, a user would have no idea why things aren't working.This PR aims to improve the error messages AND serve as the basis for a documentation PR where we lay out the main limitations.
Related Issue(s)
Checklist