-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accepting bind variables in time related function calls. #14763
Merged
harshit-gangal
merged 8 commits into
vitessio:release-17.0
from
planetscale:fix-now-bindvar
Dec 13, 2023
Merged
Fix accepting bind variables in time related function calls. #14763
harshit-gangal
merged 8 commits into
vitessio:release-17.0
from
planetscale:fix-now-bindvar
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
…ns and add tests Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal and
systay
as code owners
December 13, 2023 06:56
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 13, 2023
…dvar Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Dec 13, 2023
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
harshit-gangal
approved these changes
Dec 13, 2023
Looks like a genuine failure here due to changes
|
systay
approved these changes
Dec 13, 2023
Signed-off-by: Manan Gupta <[email protected]>
Okay, yes. I found the failure and fixed it 👍 |
Signed-off-by: Manan Gupta <[email protected]>
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the PR #12742 we changed curtime function expressions to only accept literal values instead of taking in bind variables. This however caused the problem described in #14740 where-in, the vtgates from v16 are still normalizing the query and sending bind-variables, but the v17 vttablets aren't accepting them.
This PR addresses this issue, by making v17 vttablets to continue to parse the bind-variables and it also fixes the normalizer to continue to not normalize the curtime function expressions.
Tests for all the changes have been added. Moreover, I have added running the
misc
package of vtgate queries in upgrade-downgrade tests.Related Issue(s)
Checklist
Deployment Notes