Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds test for acl #14956

Merged
merged 3 commits into from
Jan 25, 2024
Merged

test: adds test for acl #14956

merged 3 commits into from
Jan 25, 2024

Conversation

ChaitanyaD48
Copy link
Contributor

Description

Add CheckAccessActor and CheckAccessHTTP tests for MONITORING role

Related Issue(s)

Improve Unit Test Coverage #14931

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@ChaitanyaD48 ChaitanyaD48 requested a review from deepthi as a code owner January 15, 2024 17:43
Copy link
Contributor

vitess-bot bot commented Jan 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 15, 2024
@frouioui
Copy link
Member

Hello @ChaitanyaD48! Thanks for your Pull Request. It is highly related to #14943, which adds more test cases for the go/acl package.

@frouioui frouioui added Status: Duplicate Type: Testing Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9af8692) 47.33% compared to head (74d01ab) 47.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14956      +/-   ##
==========================================
- Coverage   47.33%   47.31%   -0.02%     
==========================================
  Files        1142     1142              
  Lines      239009   239009              
==========================================
- Hits       113125   113095      -30     
- Misses     117289   117328      +39     
+ Partials     8595     8586       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui
Copy link
Member

Hey @ChaitanyaD48 can you please fix the conflict on your branch?

ChaitanyaD48 and others added 2 commits January 19, 2024 22:36
Signed-off-by: Chaitanya Deshmukh <[email protected]>
Signed-off-by: ChaitanyaD48 <[email protected]>
@ChaitanyaD48
Copy link
Contributor Author

ChaitanyaD48 commented Jan 19, 2024

Hey @ChaitanyaD48 can you please fix the conflict on your branch?

I have resolved the conflicts on my branch. Please review and let me know if everything looks good now.
Thanks!

@ChaitanyaD48
Copy link
Contributor Author

@frouioui could you please review the changes in this pull request?
Thank you!

@harshit-gangal harshit-gangal merged commit 5611de3 into vitessio:main Jan 25, 2024
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants