-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adds test for acl #14956
test: adds test for acl #14956
Conversation
Signed-off-by: ChaitanyaD48 <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Hello @ChaitanyaD48! Thanks for your Pull Request. It is highly related to #14943, which adds more test cases for the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14956 +/- ##
==========================================
- Coverage 47.33% 47.31% -0.02%
==========================================
Files 1142 1142
Lines 239009 239009
==========================================
- Hits 113125 113095 -30
- Misses 117289 117328 +39
+ Partials 8595 8586 -9 ☔ View full report in Codecov by Sentry. |
Hey @ChaitanyaD48 can you please fix the conflict on your branch? |
Signed-off-by: Chaitanya Deshmukh <[email protected]>
Signed-off-by: ChaitanyaD48 <[email protected]>
I have resolved the conflicts on my branch. Please review and let me know if everything looks good now. |
@frouioui could you please review the changes in this pull request? |
Description
Add CheckAccessActor and CheckAccessHTTP tests for MONITORING role
Related Issue(s)
Improve Unit Test Coverage #14931
Checklist