refac: deprecate vitess/go/maps2 for golang.org/x/exp/maps

[EshaanAgg]

Description

Remove unneeded maps2 package since golang.org/x/exp/maps provides these as well.

Related Issue(s)

Fixes part of #14931

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[dbussink]

I don't think this is the right change here. What we want is to remove maps2 since these are functions that Go provides these days in golang.org/x/exp/maps.

[dbussink]

I don't think this is the right change here. What we want is to remove maps2 since these are functions that Go provides these days in golang.org/x/exp/maps.

@EshaanAgg Is this something you are interested in tackling? Otherwise I can clean it up as well.

[EshaanAgg]

@dbussink Thanks for the review! I have cleaned up as you instructed. Would be renaming the PR to reflect the same.

[dbussink]

Nice cleanup!

[EshaanAgg]

The code coverage workflow seems to fail, but I can't seem to figure out the reason for the same (can't see any changes in this PR that should affect those tests). Can someone help me debug that?

[ajm188]

likely a flaky test: https://github.com/vitessio/vitess/actions/runs/7543640140/job/20537054175?pr=14960#step:9:403

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c1f9c80) 47.26% compared to head (3043846) 47.25%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
go/vt/vtctl/workflow/switcher_dry_run.go	0.00%	1 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14960      +/-   ##
==========================================
- Coverage   47.26%   47.25%   -0.01%     
==========================================
  Files        1138     1138              
  Lines      238842   238842              
==========================================
- Hits       112880   112864      -16     
- Misses     117368   117377       +9     
- Partials     8594     8601       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rohit-nayak-ps]

Thanks for the contribution.