-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required tests for go/mysql/hex
#14976
Changes from 1 commit
db48a8f
ecb3b2d
0c4252c
fc8d15b
76ef13a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
/* | ||
Copyright 2024 The Vitess Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package hex | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestEncodeBytes(t *testing.T) { | ||
testCases := []struct { | ||
input []byte | ||
want []byte | ||
}{ | ||
{[]byte{0xAB, 0xCD, 0xEF}, []byte("ABCDEF")}, | ||
{[]byte{0x01, 0x23, 0x45}, []byte("012345")}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := EncodeBytes(tCase.input) | ||
assert.Equalf(t, tCase.want, got, "got %v, want %v", got, tCase.want) | ||
} | ||
} | ||
|
||
func TestEncodeUint(t *testing.T) { | ||
testCases := []struct { | ||
input uint64 | ||
want []byte | ||
}{ | ||
{0, []byte("0")}, | ||
{123, []byte("7B")}, | ||
{255, []byte("FF")}, | ||
{4096, []byte("1000")}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := EncodeUint(tCase.input) | ||
assert.Equalf(t, tCase.want, got, "got %v, want %v", got, tCase.want) | ||
} | ||
} | ||
|
||
func TestDecodeUint(t *testing.T) { | ||
testCases := []struct { | ||
input uint64 | ||
want []byte | ||
}{ | ||
{0, []byte{0}}, | ||
{123, []byte{0x01, 0x23}}, | ||
{255, []byte{0x02, 0x55}}, | ||
{4096, []byte{0x40, 0x96}}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := DecodeUint(tCase.input) | ||
assert.Equalf(t, tCase.want, got, "got %v, want %v", got, tCase.want) | ||
} | ||
} | ||
|
||
func TestDecodedLen(t *testing.T) { | ||
testCases := []struct { | ||
input []byte | ||
want int | ||
}{ | ||
{[]byte{0}, 1}, | ||
{[]byte{0x01, 0x23}, 1}, | ||
{[]byte("ABCDE"), 3}, | ||
{[]byte("0123456789ABCDEF"), 8}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := DecodedLen(tCase.input) | ||
assert.Equalf(t, tCase.want, got, "got %d, want %d", got, tCase.want) | ||
} | ||
} | ||
|
||
func TestDecodeBytes(t *testing.T) { | ||
err := DecodeBytes([]byte("testDst"), []byte("1")) | ||
assert.NoErrorf(t, err, "expected no error, got %v", err) | ||
|
||
err = DecodeBytes([]byte("testDst"), []byte("12")) | ||
assert.NoErrorf(t, err, "expected no error, got %v", err) | ||
|
||
// DecodeBytes should return an error for "é" as | ||
// hex.decode returns an error for non-ASCII characters | ||
err = DecodeBytes([]byte("testDst"), []byte("é")) | ||
assert.Errorf(t, err, "expected error to appear for invalid byte, got %v", err) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can also drop the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm...right. Done. Replaced the error message with |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just do
assert.Equal(t, tCase.want, got)
here and in the other cases. The additional stuff here doesn't seem to add much.This also applies to the other cases here in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. Makes sense; I'll proceed accordingly.