-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required tests for go/mysql/hex
#14976
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
db48a8f
Add required tests for go/mysql/hex
beingnoble03 ecb3b2d
Replace assert.Errorf with assert.Error with no message
beingnoble03 0c4252c
Replace assert.Errorf with assert.Error
beingnoble03 fc8d15b
Add error message in assert.Error
beingnoble03 76ef13a
Remove the custom message from assert.Error
beingnoble03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
/* | ||
Copyright 2024 The Vitess Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package hex | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestEncodeBytes(t *testing.T) { | ||
testCases := []struct { | ||
input []byte | ||
want []byte | ||
}{ | ||
{[]byte{0xAB, 0xCD, 0xEF}, []byte("ABCDEF")}, | ||
{[]byte{0x01, 0x23, 0x45}, []byte("012345")}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := EncodeBytes(tCase.input) | ||
assert.Equal(t, tCase.want, got) | ||
} | ||
} | ||
|
||
func TestEncodeUint(t *testing.T) { | ||
testCases := []struct { | ||
input uint64 | ||
want []byte | ||
}{ | ||
{0, []byte("0")}, | ||
{123, []byte("7B")}, | ||
{255, []byte("FF")}, | ||
{4096, []byte("1000")}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := EncodeUint(tCase.input) | ||
assert.Equal(t, tCase.want, got) | ||
} | ||
} | ||
|
||
func TestDecodeUint(t *testing.T) { | ||
testCases := []struct { | ||
input uint64 | ||
want []byte | ||
}{ | ||
{0, []byte{0}}, | ||
{123, []byte{0x01, 0x23}}, | ||
{255, []byte{0x02, 0x55}}, | ||
{4096, []byte{0x40, 0x96}}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := DecodeUint(tCase.input) | ||
assert.Equal(t, tCase.want, got) | ||
} | ||
} | ||
|
||
func TestDecodedLen(t *testing.T) { | ||
testCases := []struct { | ||
input []byte | ||
want int | ||
}{ | ||
{[]byte{0}, 1}, | ||
{[]byte{0x01, 0x23}, 1}, | ||
{[]byte("ABCDE"), 3}, | ||
{[]byte("0123456789ABCDEF"), 8}, | ||
} | ||
|
||
for _, tCase := range testCases { | ||
got := DecodedLen(tCase.input) | ||
assert.Equal(t, tCase.want, got) | ||
} | ||
} | ||
|
||
func TestDecodeBytes(t *testing.T) { | ||
err := DecodeBytes([]byte("testDst"), []byte("1")) | ||
assert.NoError(t, err) | ||
|
||
err = DecodeBytes([]byte("testDst"), []byte("12")) | ||
assert.NoError(t, err) | ||
|
||
// DecodeBytes should return an error for "é" as | ||
// hex.decode returns an error for non-ASCII characters | ||
err = DecodeBytes([]byte("testDst"), []byte("é")) | ||
assert.Error(t, err, "DecodeBytes() should have errored as src contains non-ASCII character") | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for having a custom message at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have added custom messages earlier in other tests too. So, I added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think it add a lot of value here? I think we can go for the minimal setup and only add something custom if there’s explicit value in doing so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.