Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coverage scripts #15018

Closed
wants to merge 3 commits into from
Closed

feat: add coverage scripts #15018

wants to merge 3 commits into from

Conversation

EshaanAgg
Copy link
Contributor

@EshaanAgg EshaanAgg commented Jan 23, 2024

Description

Edited the Makefile to add three new scripts:

  • coverage: This target runs the tests and generates a coverage report in the coverage.out file. It utilizes the go test command with the -coverprofile flag to collect coverage data.
    It can be run as make PACKAGE=<path to go package> coverage
    After running the same, the browser shows an HTML page indicating the current coverage.
    image

  • coverage-clean: This target removes the generated coverage file (coverage.out). It's useful for cleaning up after running coverage tests.

  • coverage-help: This target displays a usage message with information about available options and commands related to coverage.

Related Issue(s)

Fixes #15003

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Eshaan Aggarwal <[email protected]>
Copy link
Contributor

vitess-bot bot commented Jan 23, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 23, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 23, 2024
@frouioui frouioui added Component: Build/CI Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 23, 2024
@VaibhavMalik4187
Copy link
Contributor

I use the following alias to check to code coverage of any go package:
alias check_coverage="go test ./... -coverprofile=cover.out && go tool cover -html=cover.out -o coverage.html && rm cover.out && firefox coverage.html"
It is very flexible and can be used in any repository and in any directory without specifying the package name. I wonder if suggesting contributors to use a similar alias would be a better idea.

@EshaanAgg
Copy link
Contributor Author

Seems cool, but how would you customize the package that you want to test and see the reports for with this alias? Running the tests for all the packages every time is not feasible.

Comment on lines +432 to +435
coverage:
go install golang.org/x/tools/cmd/cover
go test -coverprofile=coverage.out $(PACKAGE)
go tool cover -html=coverage.out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels very similar to the already existing unit_test_cover Makefile target. The following snippet is going to be important is testing the sqlparser package:

# Handle go tool cover failures due to not handling `//line` directives, which
# the goyacc compiler adds to the generated parser in sql.go. See:
# https://github.com/golang/go/issues/41222
sed -i'' -e '/^vitess.io\/vitess\/go\/vt\/sqlparser\/yaccpar/d' coverage.out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh got it. Should I rename the same to test.coverage to avoid the target conflict?


coverage:
go install golang.org/x/tools/cmd/cover
go test -coverprofile=coverage.out $(PACKAGE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, but I often find myself using the -v flag too as it helps find failing tests. Might be worth adding

@frouioui frouioui modified the milestones: v19.0.0, v20.0.0 Feb 6, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Mar 8, 2024
Copy link
Contributor

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build/CI Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Adding a script to get code coverage results
4 participants