-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTGate Warnings: Add WarnUnshardedOnly
to warnings counter
#15033
VTGate Warnings: Add WarnUnshardedOnly
to warnings counter
#15033
Conversation
When running VTGate with the `--warn_sharded_only` flag, increment the warnings count when executing a query that is supported in an unsharded keyspace but not supported in a sharded one. Signed-off-by: Tyler Coleman <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15033 +/- ##
=======================================
Coverage 47.50% 47.50%
=======================================
Files 1149 1149
Lines 239324 239325 +1
=======================================
+ Hits 113682 113694 +12
+ Misses 117053 117044 -9
+ Partials 8589 8587 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I'll let @harshit-gangal say whether this needs a separate issue.
This PR will most likely conflict with #15010 from @maxenglander. Whichever of these is merged first, the other one will need conflict resolution before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the other one. This need conflict resolution.
…only-count Signed-off-by: Tyler Coleman <[email protected]>
Signed-off-by: Tyler Coleman <[email protected]>
Description
When running VTGate with the
--warn_sharded_only
flag, increment the warnings count when executing a query that is supported in an unsharded keyspace but not supported in a sharded one.Useful for reporting purposes.
Related Issue(s)
Checklist
Deployment Notes
N/A