Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement FROM_DAYS #15058

Merged
merged 8 commits into from
Jan 29, 2024

Make use of DateFromDayNumber in FROM_DAYS func

e44193a
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement FROM_DAYS #15058

Make use of DateFromDayNumber in FROM_DAYS func
e44193a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2024 in 0s

47.51% (+0.01%) compared to f751c83

View this Pull Request on Codecov

47.51% (+0.01%) compared to f751c83

Details

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f751c83) 47.49% compared to head (e44193a) 47.51%.

Files Patch % Lines
go/vt/vtgate/evalengine/cached_size.go 0.00% 10 Missing ⚠️
go/mysql/datetime/mydate.go 0.00% 4 Missing ⚠️
go/vt/vtgate/evalengine/fn_time.go 89.28% 2 Missing and 1 partial ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15058      +/-   ##
==========================================
+ Coverage   47.49%   47.51%   +0.01%     
==========================================
  Files        1149     1149              
  Lines      239475   239532      +57     
==========================================
+ Hits       113730   113804      +74     
+ Misses     117138   117122      -16     
+ Partials     8607     8606       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov