Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement TO_DAYS #15065

Merged
merged 5 commits into from
Jan 29, 2024

Add missing test cases from mysql docs

ec4e4ac
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement TO_DAYS #15065

Add missing test cases from mysql docs
ec4e4ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 29, 2024 in 0s

47.64% (-0.05%) compared to fd99639

View this Pull Request on Codecov

47.64% (-0.05%) compared to fd99639

Details

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (fd99639) 47.68% compared to head (ec4e4ac) 47.64%.

❗ Current head ec4e4ac differs from pull request most recent head 0f0ebf6. Consider uploading reports for the commit 0f0ebf6 to get more accurate results

Files Patch % Lines
go/vt/vtgate/evalengine/cached_size.go 0.00% 10 Missing ⚠️
go/vt/vtgate/evalengine/fn_time.go 89.28% 2 Missing and 1 partial ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 40.00% 2 Missing and 1 partial ⚠️
go/mysql/datetime/datetime.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15065      +/-   ##
==========================================
- Coverage   47.68%   47.64%   -0.05%     
==========================================
  Files        1155     1151       -4     
  Lines      240064   239761     -303     
==========================================
- Hits       114472   114228     -244     
+ Misses     116990   116927      -63     
- Partials     8602     8606       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.