Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parser to allow multiple strings one after the other #15076

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the bug described in #15075.
According to the ANSI standard, strings that follow one after the other, should be concatenated together. We see the same behaviour in MySQL.
This PR replicates this behavior in Vitess as well. We now allow multiple strings one after the other, and like MySQL we concatenate them. A new precedence rule had to be introduced in the parser to remove the shift-reduce conflicts caused by the initial changes to the grammar.

Although we parse the queries now and our results are going to match MySQL, we are not making the effort to replicate the weird field name that MySQL has. i.e. -
MySQL output -

mysql [localhost:8032] {msandbox} ((none)) > select 'b' 'a' 'c';
+-----+
| b   |
+-----+
| bac |
+-----+
1 row in set (0.00 sec)

Vitess output -

mysql [localhost:8032] {vitess} ((none)) > select 'b' 'a' 'c';
+-----+
| bac |
+-----+
| bac |
+-----+
1 row in set (0.00 sec)

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Jan 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 30, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 30, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 548 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (8dd4678) 47.69%.
Report is 77 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/evalengine/cached_size.go 0.00% 41 Missing ⚠️
go/vt/vtgate/planbuilder/operators/delete.go 0.00% 32 Missing ⚠️
.../vtgate/planbuilder/operators/delete_with_input.go 0.00% 31 Missing ⚠️
.../vtgate/planbuilder/operators/horizon_expanding.go 0.00% 31 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 25 Missing ⚠️
go/vt/vtgate/engine/delete_with_input.go 53.70% 23 Missing and 2 partials ⚠️
...tgate/planbuilder/operators/aggregation_pushing.go 0.00% 25 Missing ⚠️
go/vt/mysqlctl/backupengine.go 0.00% 24 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go 4.54% 21 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 0.00% 21 Missing ⚠️
... and 55 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15076      +/-   ##
==========================================
+ Coverage   47.29%   47.69%   +0.39%     
==========================================
  Files        1137     1155      +18     
  Lines      238684   240151    +1467     
==========================================
+ Hits       112895   114542    +1647     
+ Misses     117168   117010     -158     
+ Partials     8621     8599      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -2996,7 +2996,7 @@ INPUT
select concat(a, if(b>10, 'x' 'æ', 'y' 'ß')) from t1;
END
OUTPUT
select concat(a, if(b > 10, 'x' as `æ`, 'y' as `ß`)) from t1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where I found the issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@harshit-gangal harshit-gangal merged commit 027b277 into vitessio:main Jan 30, 2024
103 of 105 checks passed
@harshit-gangal harshit-gangal deleted the fix-multiple-strings branch January 30, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Vitess doesn't parse multiple strings
3 participants