Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplatform vttestserver build #15088

Closed
wants to merge 2 commits into from
Closed

Multiplatform vttestserver build #15088

wants to merge 2 commits into from

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jan 30, 2024 •
edited
Loading

Description

Related Issue(s)

Fixes #15034

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GrahamCampbell
Multiplatform vttestserver build
6d1a5ee 
Signed-off-by: Graham Campbell <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 30, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 30, 2024
@GrahamCampbell
Build base images on multiplatform
955732e 
Signed-off-by: Graham Campbell <[email protected]>
@GrahamCampbell
Copy link
Contributor Author

Hmmm, how are the bootstrap images pushed? Is someone doing that by hand?

@GrahamCampbell GrahamCampbell mentioned this pull request Jan 30, 2024
Open
@GrahamCampbell GrahamCampbell marked this pull request as draft January 30, 2024 12:39
@GrahamCampbell
Copy link
Contributor Author

Digging around some more, there is a lot more to this. 😭

@frouioui
Copy link
Member

frouioui commented Feb 6, 2024

Hmmm, how are the bootstrap images pushed? Is someone doing that by hand?

@GrahamCampbell correct. They are built and push by hand. Everytime there is a change to them, we increment the bootstrap version.

@GrahamCampbell GrahamCampbell deleted the arm64-vttestserver branch March 26, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: arm64 build of vitess/vttestserver
2 participants
@GrahamCampbell @frouioui