Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect tolerable replication lag even when the new primary has been provided in PRS #15090

Merged
merged 3 commits into from
Feb 4, 2024

feat: refactor code to make it more readable and add more tests

2dde718
Select commit
Loading
Failed to load commit list.
Merged

Respect tolerable replication lag even when the new primary has been provided in PRS #15090

feat: refactor code to make it more readable and add more tests
2dde718
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 4, 2024 in 1s

58.88% of diff hit (target 47.29%)

View this Pull Request on Codecov

58.88% of diff hit (target 47.29%)

Annotations

Check warning on line 240 in go/cmd/vtctldclient/command/root.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/root.go#L240 

Added line #L240 was not covered by tests

Check warning on line 125 in go/cmd/vtctldclient/command/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/schema.go#L125 

Added line #L125 was not covered by tests

Check warning on line 99 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L98-L99 

Added lines #L98 - L99 were not covered by tests

Check warning on line 107 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L106-L107 

Added lines #L106 - L107 were not covered by tests

Check warning on line 113 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L112-L113 

Added lines #L112 - L113 were not covered by tests

Check warning on line 613 in go/mysql/datetime/datetime.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/datetime/datetime.go#L613 

Added line #L613 was not covered by tests

Check warning on line 622 in go/mysql/datetime/datetime.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/datetime/datetime.go#L622 

Added line #L622 was not covered by tests

Check warning on line 90 in go/mysql/datetime/mydate.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/datetime/mydate.go#L87-L90 

Added lines #L87 - L90 were not covered by tests

Check warning on line 212 in go/mysql/flavor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/flavor.go#L212 

Added line #L212 was not covered by tests

Check warning on line 518 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L518 

Added line #L518 was not covered by tests

Check warning on line 527 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L527 

Added line #L527 was not covered by tests

Check warning on line 438 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L437-L438 

Added lines #L437 - L438 were not covered by tests

Check warning on line 452 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L452 

Added line #L452 was not covered by tests

Check warning on line 465 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L460-L465 

Added lines #L460 - L465 were not covered by tests

Check warning on line 483 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L469-L483 

Added lines #L469 - L483 were not covered by tests

Check warning on line 485 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L485 

Added line #L485 was not covered by tests

Check warning on line 253 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L252-L253 

Added lines #L252 - L253 were not covered by tests

Check warning on line 255 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L255 

Added line #L255 was not covered by tests

Check warning on line 267 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L265-L267 

Added lines #L265 - L267 were not covered by tests

Check warning on line 269 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L269 

Added line #L269 was not covered by tests

Check warning on line 273 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L271-L273 

Added lines #L271 - L273 were not covered by tests

Check warning on line 281 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L281 

Added line #L281 was not covered by tests

Check warning on line 297 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L297 

Added line #L297 was not covered by tests

Check warning on line 308 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L299-L308 

Added lines #L299 - L308 were not covered by tests

Check warning on line 315 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L314-L315 

Added lines #L314 - L315 were not covered by tests
View more details on Codecov