Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect tolerable replication lag even when the new primary has been provided in PRS #15090

Merged
merged 3 commits into from
Feb 4, 2024

feat: address review comments

87d04bd
Select commit
Loading
Failed to load commit list.
Merged

Respect tolerable replication lag even when the new primary has been provided in PRS #15090

feat: address review comments
87d04bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 4, 2024 in 1s

69.40% of diff hit (target 47.29%)

View this Pull Request on Codecov

69.40% of diff hit (target 47.29%)

Annotations

Check warning on line 240 in go/cmd/vtctldclient/command/root.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/root.go#L240 

Added line #L240 was not covered by tests

Check warning on line 125 in go/cmd/vtctldclient/command/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/schema.go#L125 

Added line #L125 was not covered by tests

Check warning on line 99 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L98-L99 

Added lines #L98 - L99 were not covered by tests

Check warning on line 113 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L112-L113 

Added lines #L112 - L113 were not covered by tests

Check warning on line 438 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L437-L438 

Added lines #L437 - L438 were not covered by tests

Check warning on line 462 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L460-L462 

Added lines #L460 - L462 were not covered by tests

Check warning on line 465 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L464-L465 

Added lines #L464 - L465 were not covered by tests

Check warning on line 472 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L469-L472 

Added lines #L469 - L472 were not covered by tests

Check warning on line 474 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L474 

Added line #L474 was not covered by tests

Check warning on line 479 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L476-L479 

Added lines #L476 - L479 were not covered by tests

Check warning on line 483 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L481-L483 

Added lines #L481 - L483 were not covered by tests

Check warning on line 485 in go/vt/mysqlctl/backupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/backupengine.go#L485 

Added line #L485 was not covered by tests

Check warning on line 253 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L252-L253 

Added lines #L252 - L253 were not covered by tests

Check warning on line 255 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L255 

Added line #L255 was not covered by tests

Check warning on line 265 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L265 

Added line #L265 was not covered by tests

Check warning on line 267 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L267 

Added line #L267 was not covered by tests

Check warning on line 269 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L269 

Added line #L269 was not covered by tests

Check warning on line 273 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L272-L273 

Added lines #L272 - L273 were not covered by tests

Check warning on line 302 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L299-L302 

Added lines #L299 - L302 were not covered by tests

Check warning on line 306 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L304-L306 

Added lines #L304 - L306 were not covered by tests

Check warning on line 308 in go/vt/mysqlctl/builtinbackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/builtinbackupengine.go#L308 

Added line #L308 was not covered by tests

Check warning on line 314 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L314 

Added line #L314 was not covered by tests

Check warning on line 351 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L351 

Added line #L351 was not covered by tests

Check warning on line 356 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L356 

Added line #L356 was not covered by tests

Check warning on line 247 in go/vt/mysqlctl/xtrabackupengine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/xtrabackupengine.go#L247 

Added line #L247 was not covered by tests
View more details on Codecov