Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalEngine: Implement TIME_TO_SEC #15094

Merged
merged 3 commits into from
Feb 5, 2024

evalEngine: Implement TIME_TO_SEC

70d761b
Select commit
Loading
Failed to load commit list.
Merged

evalEngine: Implement TIME_TO_SEC #15094

evalEngine: Implement TIME_TO_SEC
70d761b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 31, 2024 in 1s

47.70% (-0.01%) compared to 77dc0c9

View this Pull Request on Codecov

47.70% (-0.01%) compared to 77dc0c9

Details

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (77dc0c9) 47.70% compared to head (70d761b) 47.70%.
Report is 8 commits behind head on main.

❗ Current head 70d761b differs from pull request most recent head f565f88. Consider uploading reports for the commit f565f88 to get more accurate results

Files Patch % Lines
go/vt/vtgate/evalengine/fn_time.go 53.57% 9 Missing and 4 partials ⚠️
go/vt/vtgate/evalengine/cached_size.go 0.00% 10 Missing ⚠️
go/vt/vtgate/evalengine/compiler_asm.go 70.00% 2 Missing and 1 partial ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15094      +/-   ##
==========================================
- Coverage   47.70%   47.70%   -0.01%     
==========================================
  Files        1155     1155              
  Lines      240218   240275      +57     
==========================================
+ Hits       114593   114620      +27     
- Misses     117020   117047      +27     
- Partials     8605     8608       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov