Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tablet collation mismatch warning throttled #15123

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Feb 2, 2024

Description

This is a backport from an internal PR by @aquarapid. The warning which we emit when there's a mismatch between Vitess' collations and the collations in the MySQL cluster can get real noisy because it's emitted once per query. Throttle it with the log throttler.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Feb 2, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 2, 2024
@vmg vmg added Type: Internal Cleanup Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 2, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 146 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (0166c89) 70.63%.
Report is 97 commits behind head on main.

Files Patch % Lines
go/vt/mysqlctl/builtinbackupengine.go 12.90% 54 Missing ⚠️
go/vt/mysqlctl/backupengine.go 0.00% 20 Missing ⚠️
go/vt/mysqlctl/xtrabackupengine.go 0.00% 15 Missing ⚠️
go/vt/topo/keyspace.go 78.72% 10 Missing ⚠️
go/mysql/conn.go 53.84% 6 Missing ⚠️
go/vt/schemadiff/column.go 25.00% 6 Missing ⚠️
go/vt/mysqlctl/backup.go 37.50% 5 Missing ⚠️
go/mysql/capabilities/capability.go 91.48% 4 Missing ⚠️
go/mysql/query.go 77.77% 4 Missing ⚠️
go/vt/mysqlctl/schema.go 72.72% 3 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15123       +/-   ##
===========================================
+ Coverage   47.29%   70.63%   +23.33%     
===========================================
  Files        1137     1375      +238     
  Lines      238684   182225    -56459     
===========================================
+ Hits       112895   128713    +15818     
+ Misses     117168    53512    -63656     
+ Partials     8621        0     -8621     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink

This comment was marked as resolved.

@frouioui frouioui modified the milestones: v19.0.0, v20.0.0 Feb 6, 2024
@vmg vmg merged commit 4e31f60 into vitessio:main Feb 9, 2024
105 of 106 checks passed
@vmg vmg deleted the vmg/throttle-collation-warning branch February 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants