Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Multi-tenant import support in Vitess #15128

Closed
wants to merge 27 commits into from

Fix check in reverse traffic to account for keyspace routing rules. A…

6ab42cc
Select commit
Loading
Failed to load commit list.
Closed

Experimental: Multi-tenant import support in Vitess #15128

Fix check in reverse traffic to account for keyspace routing rules. A…
6ab42cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 6, 2024 in 1s

65.61% (+0.17%) compared to 7a2af6f

View this Pull Request on Codecov

65.61% (+0.17%) compared to 7a2af6f

Details

Codecov Report

Attention: Patch coverage is 41.32653% with 230 lines in your changes are missing coverage. Please review.

Project coverage is 65.61%. Comparing base (7a2af6f) to head (6ab42cc).
Report is 9 commits behind head on main.

Files Patch % Lines
...cmd/vtctldclient/command/keyspace_routing_rules.go 13.33% 52 Missing ⚠️
go/vt/vtctl/workflow/server.go 56.07% 47 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 33 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 0.00% 23 Missing ⚠️
...ldclient/command/vreplication/movetables/create.go 0.00% 18 Missing ⚠️
go/vt/vtctl/workflow/utils.go 60.52% 15 Missing ⚠️
go/vt/vtctl/workflow/materializer.go 58.33% 10 Missing ⚠️
go/vt/vtgate/vindexes/vschema.go 41.17% 10 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 8 Missing ⚠️
go/vt/topo/vschema.go 71.42% 6 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15128      +/-   ##
==========================================
+ Coverage   65.44%   65.61%   +0.17%     
==========================================
  Files        1562     1563       +1     
  Lines      193922   194239     +317     
==========================================
+ Hits       126905   127448     +543     
+ Misses      67017    66791     -226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov