-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure to handle unsupported collations well #15134
make sure to handle unsupported collations well #15134
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
CI failing on Unit Tests |
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
1dca8d0
to
341d872
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15134 +/- ##
===========================================
+ Coverage 47.29% 70.61% +23.31%
===========================================
Files 1137 1376 +239
Lines 238684 182418 -56266
===========================================
+ Hits 112895 128811 +15916
+ Misses 117168 53607 -63561
+ Partials 8621 0 -8621 ☔ View full report in Codecov by Sentry. |
This is in the v19.0.0 milestone, but was merged to 20.x. Will this be backported? |
Signed-off-by: Andres Taylor <[email protected]>
You keep me on my toes, @GrahamCampbell 😁 Here it is: #15143 |
… (#15142) Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Description
We were not handling unsupported collations well in semantic analysis and during planning.
Related Issue(s)
Fixes #15133
Checklist