-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use v3 of fossa-action and exclude maven #15140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Feb 5, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
changed the title
Use v3 of fossa-action after adding push only token
CI: Use v3 of fossa-action after adding push only token
Feb 5, 2024
mattlord
added
Component: Build/CI
Type: CI/Build
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Feb 5, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
requested review from
deepthi,
frouioui and
rohit-nayak-ps
as code owners
February 5, 2024 22:19
mattlord
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Feb 5, 2024
mattlord
changed the title
CI: Use v3 of fossa-action after adding push only token
CI: Use v3 of fossa-action with push only token
Feb 5, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
fossa_testing
branch
from
February 5, 2024 22:37
86e8140
to
26980eb
Compare
The FOSSA endpoint reported an error: You are not permitted to edit this project. Signed-off-by: Matt Lord <[email protected]>
This reverts commit 1a91867. Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
fossa_testing
branch
from
February 5, 2024 23:09
51d1cf3
to
cbf46e7
Compare
frouioui
reviewed
Feb 5, 2024
frouioui
approved these changes
Feb 5, 2024
mattlord
force-pushed
the
fossa_testing
branch
from
February 5, 2024 23:16
cbf46e7
to
c5b72d5
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
changed the title
CI: Use v3 of fossa-action with push only token
CI: Use v3 of fossa-action and exclude maven
Feb 11, 2024
dbussink
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This temporarily disables the maven based scanning of our java client (source). This is needed until we can figure out why that is broken. When run locally you can see the problem:
It gets stuck there as it's using up A LOT of memory and thus paging to disk:
It will eventually get killed by the OS (darwin kernel in my case):
This same issue is also causing fossa to get killed by the kernel's OOM thread on the GitHub Action runner, causing it to simply end/exit w/o any error in the CI logs. Example: https://github.com/vitessio/vitess/actions/runs/7788019235/job/21244889378
We don't want to exclude the java code but we are doing so for now as then we'll at least be scanning most of the project (golang) — w/o doing this we get no scanning.
We're working with the FOSSA support team to try and get the maven part working again.
Related Issue(s)
Checklist