Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use v3 of fossa-action and exclude maven #15140

Merged
merged 9 commits into from
Feb 11, 2024

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 5, 2024

Description

This temporarily disables the maven based scanning of our java client (source). This is needed until we can figure out why that is broken. When run locally you can see the problem:

❯ export FOSSA_API_KEY=<redacted>

❯ fossa analyze
Skipping pdm project at "/Users/matt/git/vitess/web/vtadmin/node_modules/npm/node_modules/node-gyp/gyp/" (default non-production path filtering)
Analyzing npm project at /Users/matt/git/vitess/web/vtadmin/
Analyzing npm project at /Users/matt/git/vitess/vitess-mixin/e2e/
Analyzing maven project at /Users/matt/git/vitess/java/
Analyzing gomod project at /Users/matt/git/vitess/vitess-mixin/
Analyzing gomod project at /Users/matt/git/vitess/
NOTE: /Users/matt/git/vitess/vitess-mixin/ analyzed using V3 Go Resolver.
   As of v3.8.5 we have changed our dynamic Go strategy. If you've analyzed this project before, results may have changed.
   See https://github.com/fossas/fossa-cli/blob/master/docs/references/strategies/languages/golang/v3-go-resolver-transition-qa.md for more information.
NOTE: /Users/matt/git/vitess/ analyzed using V3 Go Resolver.
   As of v3.8.5 we have changed our dynamic Go strategy. If you've analyzed this project before, results may have changed.
   See https://github.com/fossas/fossa-cli/blob/master/docs/references/strategies/languages/golang/v3-go-resolver-transition-qa.md for more information.
[ 0 Waiting / 1 Running / 42 Completed ]
[TASK 35] Project Analysis: MavenProjectType > Maven > Dynamic Analysis > Plugin analysis > Building dependency graph

It gets stuck there as it's using up A LOT of memory and thus paging to disk:

55500  fossa        79.8 09:01.18 30     0    72    66G+   0B     64G+   55500 917   stuck    *0[1]             0.00000 0.00000    501

It will eventually get killed by the OS (darwin kernel in my case):

[1]    55500 killed     fossa analyze

This same issue is also causing fossa to get killed by the kernel's OOM thread on the GitHub Action runner, causing it to simply end/exit w/o any error in the CI logs. Example: https://github.com/vitessio/vitess/actions/runs/7788019235/job/21244889378

We don't want to exclude the java code but we are doing so for now as then we'll at least be scanning most of the project (golang) — w/o doing this we get no scanning.

We're working with the FOSSA support team to try and get the maven part working again.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Feb 5, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 5, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 5, 2024
@mattlord mattlord changed the title Use v3 of fossa-action after adding push only token CI: Use v3 of fossa-action after adding push only token Feb 5, 2024
@mattlord mattlord added Component: Build/CI Type: CI/Build and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 5, 2024
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord marked this pull request as ready for review February 5, 2024 22:19
@mattlord mattlord removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Feb 5, 2024
@mattlord mattlord changed the title CI: Use v3 of fossa-action after adding push only token CI: Use v3 of fossa-action with push only token Feb 5, 2024
Signed-off-by: Matt Lord <[email protected]>
The FOSSA endpoint reported an error:
          You are not permitted to edit this project.

Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord changed the title CI: Use v3 of fossa-action with push only token CI: Use v3 of fossa-action and exclude maven Feb 11, 2024
@mattlord mattlord merged commit fcd5ad4 into vitessio:main Feb 11, 2024
100 checks passed
@mattlord mattlord deleted the fossa_testing branch February 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants