Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore internal tables in schema tracking #15141

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 6, 2024

Description

This PR removed internal tables to be removed from schema tracking in the GetSchema RPC and from the Foreign Key Schema definition. They are temporary tables should be ignored for foreign key planning.

Backport to v18: An issue exists on v18 which can cause queries on unexpected tables.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Feb 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 6, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (87ac5be) 70.63%.
Report is 109 commits behind head on main.

Files Patch % Lines
go/vt/mysqlctl/builtinbackupengine.go 12.90% 54 Missing ⚠️
go/vt/mysqlctl/backupengine.go 0.00% 20 Missing ⚠️
go/vt/mysqlctl/xtrabackupengine.go 0.00% 15 Missing ⚠️
go/vt/schemadiff/column.go 70.83% 7 Missing ⚠️
go/mysql/conn.go 53.84% 6 Missing ⚠️
go/vt/mysqlctl/backup.go 37.50% 5 Missing ⚠️
go/mysql/capabilities/capability.go 91.48% 4 Missing ⚠️
go/mysql/query.go 77.77% 4 Missing ⚠️
go/vt/mysqlctl/schema.go 72.72% 3 Missing ⚠️
go/vt/schemadiff/schema.go 92.10% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15141       +/-   ##
===========================================
+ Coverage   47.29%   70.63%   +23.33%     
===========================================
  Files        1137     1376      +239     
  Lines      238684   182459    -56225     
===========================================
+ Hits       112895   128876    +15981     
+ Misses     117168    53583    -63585     
+ Partials     8621        0     -8621     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal changed the title fix: ignore internal tables in GetSchema RPC fix: ignore internal tables in schema tracking Feb 6, 2024
@harshit-gangal harshit-gangal added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 6, 2024
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though still in Draft.

@harshit-gangal harshit-gangal added Backport to: release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 and removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 6, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review February 6, 2024 14:44
@frouioui frouioui merged commit aae0a6e into vitessio:main Feb 6, 2024
103 of 107 checks passed
@frouioui frouioui deleted the get-schema-fix branch February 6, 2024 15:13
vitess-bot pushed a commit that referenced this pull request Feb 6, 2024
frouioui pushed a commit to planetscale/vitess that referenced this pull request Feb 6, 2024
harshit-gangal added a commit that referenced this pull request Feb 7, 2024
harshit-gangal pushed a commit that referenced this pull request Feb 7, 2024
#15147)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Sending Queries on Temporary Table in Foreign Key mode Managed
3 participants