-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore internal tables in schema tracking #15141
Conversation
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15141 +/- ##
===========================================
+ Coverage 47.29% 70.63% +23.33%
===========================================
Files 1137 1376 +239
Lines 238684 182459 -56225
===========================================
+ Hits 112895 128876 +15981
+ Misses 117168 53583 -63585
+ Partials 8621 0 -8621 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM even though still in Draft.
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
#15147) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
#15146) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
Description
This PR removed internal tables to be removed from schema tracking in the
GetSchema
RPC and from the Foreign Key Schema definition. They are temporary tables should be ignored for foreign key planning.Backport to v18: An issue exists on v18 which can cause queries on unexpected tables.
Related Issue(s)
Checklist
Deployment Notes