Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: wrong field type returned for SUM #15192

Merged
merged 6 commits into from
Feb 12, 2024
Merged

bugfix: wrong field type returned for SUM #15192

merged 6 commits into from
Feb 12, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Feb 9, 2024 •
edited
Loading

Description

For some arithmetic operations performed in the evalengine, we were not setting the resulting decimal length correctly.
The values were correct, but since the decimal length was set wrongly, some clients didn't read all the provided decimals and got the wrong results.

Related Issue(s)

Fixes #15200

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 9, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 9, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 9, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea62cee) 67.28% compared to head (5794119) 67.32%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15192      +/-   ##
==========================================
+ Coverage   67.28%   67.32%   +0.03%     
==========================================
  Files        1560     1560              
  Lines      192264   192417     +153     
==========================================
+ Hits       129366   129543     +177     
+ Misses      62898    62874      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 9, 2024
@systay systay force-pushed the decimal-length-bug branch from 1fcafb1 to a5d4474 Compare February 10, 2024 10:55
dbussink
dbussink reviewed Feb 10, 2024
View reviewed changes
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some legit unit test failures here too

go/vt/vtgate/engine/opcode/constants.go

scale := t.Scale()
if code == AggregateAvg {
scale += 4
Copy link
Contributor

@dbussink dbussink Feb 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also have to increase size here too? I tested an AVG and the size was also increased. Which makes sense, since size for a decimal is the total number of digits, so if there's more digits behind the dot, it means the size also has to increase.

go/vt/vtgate/evalengine/expr_arithmetic.go
@@ -434,6 +438,7 @@ func (op *opArithMod) compile(c *compiler, left, right IR) (ctype, error) {
c.asm.Mod_ff()
case sqltypes.Decimal:
ct.Type = sqltypes.Decimal
ct.Scale = max(lt.Scale, rt.Scale)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to do the same with size here?

go/test/endtoend/utils/mysql.go Outdated
t.Errorf("for column %s field types do not match\nNot equal: \nMySQL: %v\nVitess: %v\n", columnName, myField.Type.String(), vtField.Type.String())
}

// ensure that Decimal types are properly sized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to check size here too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no we don't

vmg added 2 commits February 12, 2024 10:26
@vmg
constants: fix tests
d348968 
Signed-off-by: Vicent Marti <[email protected]>
@vmg
endtoend: fix backwards test
f7a5f45 
Signed-off-by: Vicent Marti <[email protected]>
@vmg vmg marked this pull request as ready for review February 12, 2024 10:55
@vmg
Copy link
Collaborator

vmg commented Feb 12, 2024 •
edited
Loading

@dbussink I'm not fixing the Size fields in this PR because they don't appear to affect correctness and their fix is significantly more involved, particularly for Decimals. We'll have to sit down and look at this together when you're back, I fear that some of the Size fields may not be computable statically! 😵

@vmg vmg added Backport to: release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 labels Feb 12, 2024
vmg added 2 commits February 12, 2024 12:00
@vmg
misc cleanups
e3b4f02 
Signed-off-by: Vicent Marti <[email protected]>
@vmg
endtoend: fix backwards tests
5794119 
Signed-off-by: Vicent Marti <[email protected]>
@systay
Copy link
Collaborator Author

systay commented Feb 12, 2024

It all looks great to me ✨ . Since I opened the PR, you'll have to approve it, @vmg

vmg
vmg approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHA, SEAL OF SELF-APPROVAL 👌

@vmg vmg merged commit cd61d85 into vitessio:main Feb 12, 2024
102 checks passed
@vmg vmg deleted the decimal-length-bug branch February 12, 2024 12:27
@vitess-bot vitess-bot bot mentioned this pull request Feb 12, 2024
Closed
vitess-bot pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot @vmg
bugfix: wrong field type returned for SUM (#15192)
210f29f 
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Co-authored-by: Vicent Marti <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 12, 2024
Merged
frouioui pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot @vmg
[release-19.0] bugfix: wrong field type returned for SUM (#15192) (#1…
74278f1 
…5206)

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Vicent Marti <[email protected]>
@GrahamCampbell GrahamCampbell mentioned this pull request Feb 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Query Serving Type: Bug
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

Bug: output fields not typed not correct
3 participants
@systay @vmg @dbussink