Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concurrency group for check labels workflow #15197

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove concurrency group for check labels workflow #15197

merged 1 commit into from
Feb 12, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 9, 2024

Description

I think this will fix the issue we have been seeing with the check labels workflow being stuck in "pending". It seems like the repeated addition or deletion of labels cancels the workflow over and over.

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 9, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 9, 2024
@frouioui frouioui added Component: Build/CI Type: CI/Build Backport to: release-17.0 Backport to: release-19.0 Needs to be back ported to release-19.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 9, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 9, 2024
@dbussink dbussink merged commit aaf82ee into main Feb 12, 2024
212 checks passed
@dbussink dbussink deleted the remove-concurrency-group-for-labels branch February 12, 2024 12:42
vitess-bot pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot
Remove concurrency group for check labels workflow (#15197)
6d8621e 
Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 12, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot
Remove concurrency group for check labels workflow (#15197)
f1b492f 
Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 12, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot
Remove concurrency group for check labels workflow (#15197)
51e7b95 
Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 12, 2024
Merged
frouioui pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot
[release-18.0] Remove concurrency group for check labels workflow (#1…
257fecb 
…5197) (#15208)

Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot
[release-17.0] Remove concurrency group for check labels workflow (#1…
71b1d8d 
…5197) (#15207)

Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui pushed a commit that referenced this pull request Feb 12, 2024
@vitess-bot
[release-19.0] Remove concurrency group for check labels workflow (#1…
adc6a28 
…5197) (#15209)

Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi deepthi approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@frouioui @deepthi @ajm188 @dbussink