Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delete with multi-tables related by foreign keys #15218

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Feb 13, 2024

Description

This PR fixes the issue in #15191

The only way to resolve the problem pointed out in #15191 is to use the DMLWithInput operator that we use for Delete with Limit planning. This PR makes this change.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Feb 13, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 13, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 13, 2024
@GuptaManan100 GuptaManan100 changed the title feat: fix the failure the fuzzer found Fix Delete with multi-tables related by foreign keys Feb 13, 2024
@GuptaManan100 GuptaManan100 added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 13, 2024
@GuptaManan100 GuptaManan100 marked this pull request as ready for review February 13, 2024 15:53
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696fe0e) 67.41% compared to head (bdb8dc8) 67.42%.
Report is 11 commits behind head on main.

❗ Current head bdb8dc8 differs from pull request most recent head 9170c36. Consider uploading reports for the commit 9170c36 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15218   +/-   ##
=======================================
  Coverage   67.41%   67.42%           
=======================================
  Files        1560     1560           
  Lines      192752   192760    +8     
=======================================
+ Hits       129952   129972   +20     
+ Misses      62800    62788   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…put planning, now that it is being used for multi-table deletes

Signed-off-by: Manan Gupta <[email protected]>
@GuptaManan100 GuptaManan100 added the Backport to: release-19.0 Needs to be back ported to release-19.0 label Feb 15, 2024
@GuptaManan100
Copy link
Member Author

I've added the backport to release-19.0 label, because we have support for delete with multi-tables in presence of foreign keys there as well, and this bug causes incorrect results, which is reason to backport this fix.

@frouioui frouioui merged commit c0b303d into vitessio:main Feb 15, 2024
101 checks passed
@frouioui frouioui deleted the fix-multi-delete-fk branch February 15, 2024 16:04
GuptaManan100 added a commit that referenced this pull request Feb 16, 2024
harshit-gangal pushed a commit that referenced this pull request Feb 16, 2024
…15218) (#15255)

Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Incorrect results for multi-table delete query with foreign keys
3 participants