-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Delete with multi-tables related by foreign keys #15218
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15218 +/- ##
=======================================
Coverage 67.41% 67.42%
=======================================
Files 1560 1560
Lines 192752 192760 +8
=======================================
+ Hits 129952 129972 +20
+ Misses 62800 62788 -12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
…put planning, now that it is being used for multi-table deletes Signed-off-by: Manan Gupta <[email protected]>
I've added the backport to release-19.0 label, because we have support for delete with multi-tables in presence of foreign keys there as well, and this bug causes incorrect results, which is reason to backport this fix. |
Signed-off-by: Manan Gupta <[email protected]>
…15218) (#15255) Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Description
This PR fixes the issue in #15191
The only way to resolve the problem pointed out in #15191 is to use the
DMLWithInput
operator that we use for Delete with Limit planning. This PR makes this change.Related Issue(s)
Checklist
Deployment Notes