Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use FOSSA push-only token for license scans on PRs #15222

Merged
merged 1 commit into from
Feb 13, 2024
Merged

CI: Use FOSSA push-only token for license scans on PRs #15222

merged 1 commit into from
Feb 13, 2024

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 13, 2024 •
edited
Loading

Description

Now that we have the FOSSA license scan working again on merges to main, let's enable the scan on PRs (opened using forks) again by leveraging a push-only token. You can see a successful run here: https://github.com/vitessio/vitess/actions/runs/7893049759/job/21540828304?pr=15222

This gets us back to where we were prior to having to disable it in #14119.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@mattlord
Try to use fossa push-only token again
5a6b209 
So that we can run the license scan on PRs opened
with forks.

Signed-off-by: Matt Lord <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 13, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 13, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 13, 2024
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 13, 2024
@mattlord mattlord changed the title Try to use fossa push-only token again CI: Try to use fossa push-only token again Feb 13, 2024
@mattlord mattlord marked this pull request as ready for review February 13, 2024 21:52
@mattlord mattlord changed the title CI: Try to use fossa push-only token again CI: Use fossa push-only token for license scans on PRs Feb 13, 2024
@mattlord mattlord changed the title CI: Use fossa push-only token for license scans on PRs CI: Use FOSSA push-only token for license scans on PRs Feb 13, 2024
@frouioui frouioui merged commit fc5b6d0 into vitessio:main Feb 13, 2024
109 of 114 checks passed
@frouioui frouioui deleted the fossa_push-only branch February 13, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mattlord @ajm188 @frouioui