Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] More vtctldclient updates in tests #15276

Merged
merged 18 commits into from
Feb 21, 2024

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 17, 2024

Description

Builds on #15270 but still doesn't finish the work.

Related Issue(s)

#15273

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Andrew Mason added 11 commits February 16, 2024 14:37
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
ugh
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Copy link
Contributor

vitess-bot bot commented Feb 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 17, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696fe0e) 67.41% compared to head (de1ff63) 67.48%.
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15276      +/-   ##
==========================================
+ Coverage   67.41%   67.48%   +0.07%     
==========================================
  Files        1560     1561       +1     
  Lines      192752   193355     +603     
==========================================
+ Hits       129952   130495     +543     
- Misses      62800    62860      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajm188 ajm188 added Type: Internal Cleanup Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 17, 2024
Andrew Mason added 5 commits February 17, 2024 13:57
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
ugh
Signed-off-by: Andrew Mason <[email protected]>
Andrew Mason added 2 commits February 20, 2024 08:54
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 changed the title [e2e] vtctldclient update [e2e] More vtctldclient updates in tests Feb 20, 2024
@ajm188 ajm188 marked this pull request as ready for review February 20, 2024 13:56
@ajm188 ajm188 requested a review from mattlord February 20, 2024 13:56
@@ -133,7 +133,7 @@ func TestServingChange(t *testing.T) {

// changing rdonly tablet to spare (non serving).
rdonlyTablet := clusterInstance.Keyspaces[0].Shards[0].Rdonly()
err = clusterInstance.VtctlclientProcess.ExecuteCommand("ChangeTabletType", rdonlyTablet.Alias, "replica")
err = clusterInstance.VtctldClientProcess.ExecuteCommand("ChangeTabletType", rdonlyTablet.Alias, "replica")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but each of these test packages should be renamed to be descriptive instead of being called 1,2,3,4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajm188 ajm188 merged commit 0adb706 into vitessio:main Feb 21, 2024
102 checks passed
@ajm188 ajm188 deleted the andrew/e2e-vtctld-part2 branch February 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants