Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support union statements with ctes #15312

Merged
merged 2 commits into from
Feb 21, 2024
Merged

planner: support union statements with ctes #15312

merged 2 commits into from
Feb 21, 2024

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Feb 21, 2024 •
edited
Loading

Description

Support WITH ... SELECT ... UNION ... SELECT CTE syntax.

Related Issue(s)

#15311

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@maxenglander
planner: format union with
912a690 
Signed-off-by: Max Englander <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 21, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 21, 2024
@maxenglander maxenglander changed the title planner: format union with planner: support union statements with ctes Feb 21, 2024
@maxenglander maxenglander removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 21, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (af38099) 67.49% compared to head (9f2b9da) 67.55%.
Report is 7 commits behind head on main.

Files Patch % Lines
go/vt/sqlparser/ast_format.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15312      +/-   ##
==========================================
+ Coverage   67.49%   67.55%   +0.05%     
==========================================
  Files        1561     1561              
  Lines      193355   193389      +34     
==========================================
+ Hits       130512   130644     +132     
+ Misses      62843    62745      -98

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxenglander maxenglander marked this pull request as ready for review February 21, 2024 01:55
@maxenglander maxenglander added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Feb 21, 2024
dbussink
dbussink reviewed Feb 21, 2024
View reviewed changes
go/vt/sqlparser/ast_format.go
@@ -74,6 +74,10 @@ func (node *CommentOnly) Format(buf *TrackedBuffer) {

// Format formats the node.
func (node *Union) Format(buf *TrackedBuffer) {
if node.With != nil {
buf.astPrintf(node, "%v", node.With)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxenglander Can you also add a unit test for this to the sqlparser package?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go/vt/sqlparser/parse_test.go is a good place for this

@systay systay removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Feb 21, 2024
@GrahamCampbell
Copy link
Contributor

Any chance we can treat this as a bug in the CTE implementation and backport to v19?

@dbussink dbussink added the Backport to: release-19.0 Needs to be back ported to release-19.0 label Feb 21, 2024
@maxenglander
add test for sqlparser
9f2b9da 
Signed-off-by: Max Englander <[email protected]>
@dbussink dbussink added Type: Bug and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Feb 21, 2024
dbussink
dbussink approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked this as a bug, since the parser always should roundtrip queries properly but that doesn't happen here.

@dbussink dbussink merged commit a9b2c18 into vitessio:main Feb 21, 2024
104 checks passed
@dbussink dbussink deleted the maxeng-ctes-unions branch February 21, 2024 16:17
vitess-bot pushed a commit that referenced this pull request Feb 21, 2024
@vitess-bot
planner: support union statements with ctes (#15312)
19f0dcc 
Signed-off-by: Max Englander <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 21, 2024
Merged
dbussink pushed a commit that referenced this pull request Feb 21, 2024
@vitess-bot
[release-19.0] planner: support union statements with ctes (#15312) (#…
278a377 
…15324)

Signed-off-by: Max Englander <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Query Serving Type: Bug
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxenglander @GrahamCampbell @dbussink @systay