Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memory check for runners for VTOrc tests #15317

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add memory check for runners for VTOrc tests #15317

merged 1 commit into from
Feb 21, 2024

Conversation

GuptaManan100
Copy link
Member

Description

This PR adds a memory check for the runners that run VTOrc workflows because they require a lot of memory and can't run on any runner with less than 16GB RAM.

The changes were experimented and tested in #15316

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 21, 2024
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 21, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 21, 2024
dbussink
dbussink reviewed Feb 21, 2024
View reviewed changes
test/ci_workflow_gen.go
@@ -154,6 +157,7 @@ type unitTest struct {
type clusterTest struct {
Name, Shard, Platform string
FileName string
MemoryCheck bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we turn this into a int representing GB needed so we could also add this easily to other templates (with different values) if we need to? Or is that premature at this point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favor. But also fine to merge as is for now and to iterate later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can extend it when we need it.

shlomi-noach
shlomi-noach approved these changes Feb 21, 2024
View reviewed changes
test/ci_workflow_gen.go
@@ -154,6 +157,7 @@ type unitTest struct {
type clusterTest struct {
Name, Shard, Platform string
FileName string
MemoryCheck bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favor. But also fine to merge as is for now and to iterate later.

@GuptaManan100 GuptaManan100 merged commit c982a04 into vitessio:main Feb 21, 2024
112 checks passed
@GuptaManan100 GuptaManan100 deleted the vtorc-check-mem-usage branch February 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@dbussink dbussink dbussink approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @dbussink @shlomi-noach