Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablet: remove max-waiters setting #15323

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Feb 21, 2024

Description

The new Connection Pool implementation in #14034 no longer allows configuring the maximum amount of waiters in the pool, as it uses uses heuristics (such as maximum wait time) to decide when to start dropping clients under load.

We forgot to remove the flag from the list of CLI flags, however. This PR marks them as deprecated so they can be removed in a future release.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Feb 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 21, 2024
@vmg vmg added Type: Bug Component: CLI Backport to: release-19.0 Needs to be back ported to release-19.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 21, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 21, 2024
Signed-off-by: Vicent Marti <[email protected]>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (696fe0e) 67.41% compared to head (3e3a39b) 67.56%.
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15323      +/-   ##
==========================================
+ Coverage   67.41%   67.56%   +0.14%     
==========================================
  Files        1560     1561       +1     
  Lines      192752   193389     +637     
==========================================
+ Hits       129952   130663     +711     
+ Misses      62800    62726      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vicent Marti <[email protected]>
@vmg vmg merged commit e163c9e into vitessio:main Feb 21, 2024
102 checks passed
@vmg vmg deleted the vmg/max-waiter-flag branch February 21, 2024 17:03
vitess-bot pushed a commit that referenced this pull request Feb 21, 2024
dbussink pushed a commit that referenced this pull request Feb 21, 2024
Signed-off-by: Vicent Marti <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: CLI Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: queryserver-config-*-pool-waiter-cap flags have no effect in v19
3 participants