Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type coercion between the sides of an UNION #15340

Merged
merged 6 commits into from
Mar 8, 2024

orderby: add test

ee0f9b4
Select commit
Loading
Failed to load commit list.
Merged

Fix type coercion between the sides of an UNION #15340

orderby: add test
ee0f9b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 8, 2024 in 1s

90.50% of diff hit (target 65.72%)

View this Pull Request on Codecov

90.50% of diff hit (target 65.72%)

Annotations

Check warning on line 141 in go/vt/vtgate/engine/concatenate.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/engine/concatenate.go#L141

Added line #L141 was not covered by tests

Check warning on line 156 in go/vt/vtgate/engine/concatenate.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/engine/concatenate.go#L156

Added line #L156 was not covered by tests

Check warning on line 438 in go/vt/vtgate/engine/concatenate.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/engine/concatenate.go#L438

Added line #L438 was not covered by tests

Check warning on line 74 in go/vt/vtgate/engine/distinct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/engine/distinct.go#L74

Added line #L74 was not covered by tests

Check warning on line 84 in go/vt/vtgate/engine/distinct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/engine/distinct.go#L84

Added line #L84 was not covered by tests

Check warning on line 86 in go/vt/vtgate/engine/distinct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/engine/distinct.go#L86

Added line #L86 was not covered by tests

Check warning on line 68 in go/vt/vtgate/evalengine/api_type_aggregation.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/evalengine/api_type_aggregation.go#L68

Added line #L68 was not covered by tests

Check warning on line 102 in go/vt/vtgate/evalengine/compiler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/evalengine/compiler.go#L102

Added line #L102 was not covered by tests

Check warning on line 119 in go/vt/vtgate/evalengine/eval.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/evalengine/eval.go#L119

Added line #L119 was not covered by tests

Check warning on line 88 in go/vt/vtgate/evalengine/eval_numeric.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/evalengine/eval_numeric.go#L87-L88

Added lines #L87 - L88 were not covered by tests

Check warning on line 210 in go/vt/vtgate/planbuilder/operators/union_merging.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/planbuilder/operators/union_merging.go#L210

Added line #L210 was not covered by tests

Check warning on line 213 in go/vt/vtgate/planbuilder/operators/union_merging.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/planbuilder/operators/union_merging.go#L213

Added line #L213 was not covered by tests

Check warning on line 144 in go/vt/vtgate/semantics/table_collector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/semantics/table_collector.go#L144

Added line #L144 was not covered by tests

Check warning on line 150 in go/vt/vtgate/semantics/table_collector.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtgate/semantics/table_collector.go#L150

Added line #L150 was not covered by tests