-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v20 changelog docs for PR #15030 #15367
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for having kept track of this.
@timvaillancourt seems like you missed signing that last commit. Our DCO check is angry. @frouioui the release notes failing is not very informative. do you if we could we make these checks a bit more verbose if they fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I got it exactly right but I thought it was worth clarifying.
oh @timvaillancourt the DCO check is failing. You'll need to amend the commit with a signoff and force-push it. |
@frouioui can you look at the static check failure? It's from |
d4b3979
to
546220f
Compare
Signed-off-by: Tim Vaillancourt <[email protected]>
546220f
to
2bf28bd
Compare
@systay oh, fixed now I think (after creating a bit of a mess I force-pushed over 😅) |
Signed-off-by: Florent Poinsard <[email protected]>
@deepthi done, just had to merge |
Description
This PR adds a changelog entry to v20 for #15030 now that a changelog subdir exists
Related Issue(s)
#15030
Checklist
Deployment Notes