Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Make connection killing resilient to MySQL hangs #15411

Closed
wants to merge 1 commit into from
Closed

[release-19.0] Make connection killing resilient to MySQL hangs #15411

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link
Contributor

Backports #14500. Note that #14500 was included in the v19.0.0 milestone, but only ever merged into the 20.0 branch without a backport (until now).

@arthurschreiber @vmg
@danieljoos @GrahamCampbell
Make connection killing resilient to MySQL hangs (vitessio#14500)
23c3e0f 
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Daniel Joos <[email protected]>
Co-authored-by: Vicent Marti <[email protected]>
Co-authored-by: Daniel Joos <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 6, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Mar 6, 2024
@systay systay mentioned this pull request Mar 5, 2024
Closed
38 tasks
@systay systay modified the milestones: v19.0.0, v19.0.1 Mar 6, 2024
@deepthi
Copy link
Member

deepthi commented Mar 6, 2024

@GrahamCampbell is this affecting a production deployment? I'm sorry this missed the cutoff for v19. We would normally not include anything but the most critical bugs in a patch release.

@GrahamCampbell
Copy link
Contributor Author

Nah, this is totally not urgent. I just noticed this probably should go into 19.0, and it was basically no work for me to do the cherry-pick, so I did.

@frouioui frouioui added Type: Bug Component: Query Serving Backport This is a backport and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 6, 2024
@deepthi
Copy link
Member

deepthi commented Mar 6, 2024

Closing for now, we can re-open if necessary.

@deepthi deepthi closed this Mar 6, 2024
@GrahamCampbell GrahamCampbell deleted the release-19.0-fix-conn-kill-hang branch March 6, 2024 21:50
@GrahamCampbell GrahamCampbell mentioned this pull request May 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@GrahamCampbell @deepthi @systay @frouioui @arthurschreiber