Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view tracking on sharded keyspace #15436

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 11, 2024

Description

When vtgate receives SELECT * queries and possesses authoritative column information for the tables in the query, it expands * into the actual column list, simplifying subsequent planning.

This column information is sourced from the schema tracker, which experiences a slight delay in reflecting schema changes in vtgate. Previously, following an ALTER TABLE that modified the column list, an immediate ALTER VIEW incorporating a SELECT * led vtgate to expand the columns using outdated information from the schema tracker, causing the resultant view to misrepresent the updated schema.

The remedy involves refraining from expanding columns in CREATE/ALTER VIEW statements, allowing MySQL to handle column expansion. The schema tracker then forwards the view definition to vtgate, ensuring consistency.

However, a temporal lag may persist; if a view is queried immediately post-alteration, it might display the previous definition until vtgate receives the updated information. Unlike before, where the view would permanently display an incorrect definition, this issue is now transient.

Related Issue(s)

Fixes #15456

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Mar 11, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 11, 2024
@harshit-gangal harshit-gangal added Type: Bug Component: Query Serving Backport to: release-17.0 Backport to: release-19.0 Needs to be back ported to release-19.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 11, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (4c70c7e) to head (1a19f89).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15436   +/-   ##
=======================================
  Coverage   65.64%   65.64%           
=======================================
  Files        1562     1563    +1     
  Lines      194318   194370   +52     
=======================================
+ Hits       127553   127589   +36     
- Misses      66765    66781   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andres Taylor <[email protected]>
@systay systay added Backport to: release-19.0 Needs to be back ported to release-19.0 and removed Backport to: release-17.0 Backport to: release-19.0 Needs to be back ported to release-19.0 labels Mar 12, 2024
Signed-off-by: Andres Taylor <[email protected]>
@systay systay marked this pull request as ready for review March 12, 2024 11:04
systay added 2 commits March 12, 2024 12:26
Signed-off-by: Andres Taylor <[email protected]>
@systay systay mentioned this pull request Mar 13, 2024
21 tasks
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

go/vt/vtgate/planbuilder/ddl.go Outdated Show resolved Hide resolved
@harshit-gangal harshit-gangal merged commit b7ef410 into vitessio:main Mar 14, 2024
102 checks passed
@harshit-gangal harshit-gangal deleted the views-sharded branch March 14, 2024 08:43
systay added a commit that referenced this pull request Mar 14, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
systay added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALTER VIEW does not pick up column changes
4 participants