-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemadiff
: remove ForeignKeyLoopError
and loop detection logic
#15507
Merged
shlomi-noach
merged 1 commit into
vitessio:main
from
planetscale:schemadiff-no-fk-loop-error
Mar 18, 2024
Merged
schemadiff
: remove ForeignKeyLoopError
and loop detection logic
#15507
shlomi-noach
merged 1 commit into
vitessio:main
from
planetscale:schemadiff-no-fk-loop-error
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 18, 2024
shlomi-noach
changed the title
schemadiff: remove
Mar 18, 2024
ForeignKeyLoopError
and loop detection logicschemadiff
: remove ForeignKeyLoopError
and loop detection logic
shlomi-noach
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 18, 2024
dbussink
approved these changes
Mar 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15507 +/- ##
==========================================
- Coverage 67.41% 65.65% -1.77%
==========================================
Files 1560 1563 +3
Lines 192752 194421 +1669
==========================================
- Hits 129952 127638 -2314
- Misses 62800 66783 +3983 ☔ View full report in Codecov by Sentry. |
GuptaManan100
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #15431 and #15430, this PR removes altogether all loop/cycle analysis logic and removes
ForeignKeyLoopError
.The rationale is that
schemadiff
should support anythingMySQL
supports. Some foreign key loop scenarios are unsupported by Query Serving, but the Query Serving logic is more intricate and should not be applied nor duplicated byschemadiff
.Related Issue(s)
#15430
Checklist
Deployment Notes