-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove keyspace from column during query builder #15514
fix: remove keyspace from column during query builder #15514
Conversation
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15514 +/- ##
==========================================
+ Coverage 65.69% 65.70% +0.01%
==========================================
Files 1564 1562 -2
Lines 194588 194438 -150
==========================================
- Hits 127832 127753 -79
+ Misses 66756 66685 -71 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…15514) (#15517) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…15514) (#15516) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
Description
This PR removes the keyspace information from the final query sent down to vttablet for execution as the database name and keyspace name can be different.
This was caused by to recent change in fixing the order by, group by and having clause column resolution logic to match the MySQL rules.
Related Issue(s)
Checklist